[Vega] Fix data[].url.body.runtime_mappings param#253560
Merged
markov00 merged 9 commits intoelastic:mainfrom Feb 18, 2026
Merged
[Vega] Fix data[].url.body.runtime_mappings param#253560markov00 merged 9 commits intoelastic:mainfrom
data[].url.body.runtime_mappings param#253560markov00 merged 9 commits intoelastic:mainfrom
Conversation
nickofthyme
added
release_note:fix
backport:all-open
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
markov00
approved these changes
Feb 18, 2026
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Looks good to me, discussed together with Nick yesterday
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Feb 18, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit 6234793) # Conflicts: # src/platform/plugins/private/vis_types/vega/public/data_model/search_api.test.ts
nickofthyme
added
v9.3.1
v9.2.6
backport:version
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Feb 18, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit 6234793) # Conflicts: # src/platform/plugins/private/vis_types/vega/public/data_model/search_api.test.ts
markov00
added a commit
that referenced
this pull request
Feb 18, 2026
…253680) # Backport This will backport the following commits from `main` to `9.3`: - [[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)](#253560) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2026-02-18T08:14:54Z","message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v9.4.0"],"title":"[Vega] Fix `data[].url.body.runtime_mappings` param","number":253560,"url":"https://github.com/elastic/kibana/pull/253560","mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/253560","number":253560,"mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}}]}] BACKPORT--> --------- Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
markov00
added a commit
that referenced
this pull request
Feb 18, 2026
…253787) # Backport This will backport the following commits from `main` to `9.2`: - [[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)](#253560) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2026-02-18T08:14:54Z","message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v9.4.0"],"title":"[Vega] Fix `data[].url.body.runtime_mappings` param","number":253560,"url":"https://github.com/elastic/kibana/pull/253560","mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/253560","number":253560,"mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}}]}] BACKPORT--> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 19, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a breaking change caused by upgrading the elasticsearch js client to
9.xwhere we started to ignore thedata[].url.body.runtime_mappingsin favor ofdata[].url.runtime_mappings.Fixes #253545
Details
In #208776 when upgrading to the
9.xES client, we changed the code to point at the requestparamsinstead ofparams.body. Specifically here.Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Release Notes
Fixes a bug where
runtime_mappingswhere ignored or overridden in a Vega spec when defined indata[].url.body. Note, thedata[].url.bodyproperty was deprecated inkibana@v8.0and properties moved todata[].url.