Skip to content

[OneDiscover][UnifiedDataTable] Apply compact Display options Popover layout#210180

Merged
akowalska622 merged 10 commits intoelastic:mainfrom
akowalska622:188066-onediscover-change-layout-of-display-options-popover
Feb 12, 2025
Merged

[OneDiscover][UnifiedDataTable] Apply compact Display options Popover layout#210180
akowalska622 merged 10 commits intoelastic:mainfrom
akowalska622:188066-onediscover-change-layout-of-display-options-popover

Conversation

@akowalska622
Copy link
Contributor

@akowalska622 akowalska622 commented Feb 7, 2025

Summary

Closes #203377

PR changes visual style of data table options popover, as per this mockup (with couple of adjustments mentioned below):
image

Note

EDIT
showDisplaySelector customRender in EUI allows us to customize position of controls. I've changed UnifiedDataTableAdditionalDisplaySettings to accept density control as a prop and encapsulated logic for order of controls within this component.

Changes within this PR:

Change range slider style

  1. Change range slider style
  2. Make the picker more compact, following EUI pattern (no horizontal lines, smaller padding)
  3. Move Sample size up

Things we decided not to solve within this PR:
1. Move Sample size up
2. Rename Density to Cell density
4. Add show row stripes toggle

Old view:
Screenshot 2025-02-07 at 13 12 49

New view:
Screenshot 2025-02-10 at 13 52 44

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
- [ ] Flaky Test Runner was used on any tests changed

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@akowalska622 akowalska622 added release_note:enhancement Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// Project:OneDiscover Enrich Discover with contextual awareness labels Feb 7, 2025
@akowalska622 akowalska622 self-assigned this Feb 7, 2025
@akowalska622
Copy link
Contributor Author

/ci

@akowalska622 akowalska622 requested a review from l-suarez February 7, 2025 12:26
@akowalska622
Copy link
Contributor Author

/ci

@akowalska622 akowalska622 marked this pull request as ready for review February 7, 2025 14:18
@akowalska622 akowalska622 requested review from a team as code owners February 7, 2025 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@akowalska622
Copy link
Contributor Author

@elasticmachine merge upstream

@akowalska622 akowalska622 removed the request for review from l-suarez February 10, 2025 13:02
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and it works as expected, thanks! I left a couple of minor nits, but nothing blocking.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 538.0KB 538.3KB +249.0B
discover 847.6KB 847.9KB +249.0B
esqlDataGrid 191.1KB 191.4KB +249.0B
securitySolution 24.9MB 24.9MB +1.5KB
slo 878.4KB 878.6KB +249.0B
total +2.4KB

History

cc @akowalska622

@akowalska622 akowalska622 merged commit aa9c4b5 into elastic:main Feb 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness release_note:enhancement Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.1.0

5 participants