[OneDiscover][UnifiedDataTable] Apply compact Display options Popover layout#210180
Merged
akowalska622 merged 10 commits intoelastic:mainfrom Feb 12, 2025
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
PhilippeOberti
approved these changes
Feb 7, 2025
Contributor
Author
|
@elasticmachine merge upstream |
akowalska622
commented
Feb 10, 2025
src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx
Show resolved
Hide resolved
davismcphee
approved these changes
Feb 11, 2025
Contributor
davismcphee
left a comment
There was a problem hiding this comment.
Code changes look good and it works as expected, thanks! I left a couple of minor nits, but nothing blocking.
src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx
Show resolved
Hide resolved
...ages/shared/kbn-unified-data-table/src/components/data_table_additional_display_settings.tsx
Outdated
Show resolved
Hide resolved
...ages/shared/kbn-unified-data-table/src/components/data_table_additional_display_settings.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #203377
PR changes visual style of data table options popover, as per this mockup (with couple of adjustments mentioned below):

Note
EDIT
showDisplaySelector customRender in EUI allows us to customize position of controls. I've changed
UnifiedDataTableAdditionalDisplaySettingsto accept density control as a prop and encapsulated logic for order of controls within this component.Changes within this PR:
Change range slider style
Sample sizeupThings we decided not to solve within this PR:
1. MoveSample sizeup2. Rename
DensitytoCell density4. Add
show row stripestoggleOld view:

New view:

Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.- [ ] Flaky Test Runner was used on any tests changedrelease_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.