[ML] AIOps Hides saved query controls#210556
Merged
jgowdyelastic merged 5 commits intoelastic:mainfrom Feb 12, 2025
Merged
Conversation
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Can you hide the query controls from the data visualizer page too?
…c/kibana into hiding-saved-query-controls
Member
Author
Updated in 01c5eeb |
jgowdyelastic
added
release_note:fix
:ml
backport:version
Contributor
|
Pinging @elastic/ml-ui (:ml) |
nickofthyme
approved these changes
Feb 12, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 12, 2025
The AIOps pages in ML make use of the shared query bar component, but do not support saved queries. By having the load and save query options in the menu, it can give the impression that these options are generally available but for some reason cannot be used. This PR adds a new optional flag which allows the load and save options to be hidden from the menu. The flag defaults to always showing the options. Fixes elastic#209152 **Before**  **After**  (cherry picked from commit 36c764e) # Conflicts: # src/platform/plugins/shared/unified_search/public/query_string_input/query_bar_menu_panels.tsx
jgowdyelastic
added a commit
that referenced
this pull request
Feb 13, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps Hiding saved query controls (#210556)](#210556) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T19:52:30Z","message":"[ML] AIOps Hiding saved query controls (#210556)\n\nThe AIOps pages in ML make use of the shared query bar component, but do\r\nnot support saved queries.\r\nBy having the load and save query options in the menu, it can give the\r\nimpression that these options are generally available but for some\r\nreason cannot be used.\r\nThis PR adds a new optional flag which allows the load and save options\r\nto be hidden from the menu.\r\nThe flag defaults to always showing the options.\r\n\r\nFixes https://github.com/elastic/kibana/issues/209152\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"36c764ebf722455a412416d48d48c737feb30e71","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:ML/AIOps","backport:version","v9.1.0","v8.19.0"],"title":"[ML] AIOps Hiding saved query controls","number":210556,"url":"https://github.com/elastic/kibana/pull/210556","mergeCommit":{"message":"[ML] AIOps Hiding saved query controls (#210556)\n\nThe AIOps pages in ML make use of the shared query bar component, but do\r\nnot support saved queries.\r\nBy having the load and save query options in the menu, it can give the\r\nimpression that these options are generally available but for some\r\nreason cannot be used.\r\nThis PR adds a new optional flag which allows the load and save options\r\nto be hidden from the menu.\r\nThe flag defaults to always showing the options.\r\n\r\nFixes https://github.com/elastic/kibana/issues/209152\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"36c764ebf722455a412416d48d48c737feb30e71"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210556","number":210556,"mergeCommit":{"message":"[ML] AIOps Hiding saved query controls (#210556)\n\nThe AIOps pages in ML make use of the shared query bar component, but do\r\nnot support saved queries.\r\nBy having the load and save query options in the menu, it can give the\r\nimpression that these options are generally available but for some\r\nreason cannot be used.\r\nThis PR adds a new optional flag which allows the load and save options\r\nto be hidden from the menu.\r\nThe flag defaults to always showing the options.\r\n\r\nFixes https://github.com/elastic/kibana/issues/209152\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"36c764ebf722455a412416d48d48c737feb30e71"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
andrew-goldstein
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 11, 2025
andrew-goldstein
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AIOps pages in ML make use of the shared query bar component, but do not support saved queries.
By having the load and save query options in the menu, it can give the impression that these options are generally available but for some reason cannot be used.
This PR adds a new optional flag which allows the load and save options to be hidden from the menu.
The flag defaults to always showing the options.
Fixes #209152
Before
After
