[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges#213666
Merged
andrew-goldstein merged 1 commit intoelastic:mainfrom Mar 10, 2025
Conversation
andrew-goldstein
added
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
… markdown with XL badges This PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <elastic#213228>. It also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.  #### Details - The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below: **Before**  **After**  - The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below: **Before**  **After** 
andrew-goldstein
force-pushed
the
ad_overflow_issue_213228
branch
from
94ffd15 to
94a629d
Compare
angorayc
approved these changes
Mar 10, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
…kdown with XL badges (elastic#213666) ### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges This PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <elastic#213228>. It also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.  #### Details - The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below: **Before**  **After**  - The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below: **Before**  **After**  (cherry picked from commit ecdea5a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
…kdown with XL badges (elastic#213666) ### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges This PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <elastic#213228>. It also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.  #### Details - The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below: **Before**  **After**  - The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below: **Before**  **After**  (cherry picked from commit ecdea5a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
…kdown with XL badges (elastic#213666) ### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges This PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <elastic#213228>. It also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.  #### Details - The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below: **Before**  **After**  - The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below: **Before**  **After**  (cherry picked from commit ecdea5a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2025
…or markdown with XL badges (#213666) (#213774) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)](#213666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T15:34:35Z","message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.18.0","v9.1.0","v8.19.0","v8.18.1"],"title":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges","number":213666,"url":"https://github.com/elastic/kibana/pull/213666","mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213666","number":213666,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
Contributor
Author
Testing notes (
|
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2025
…for markdown with XL badges (#213666) (#213773) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)](#213666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T15:34:35Z","message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.18.0","v9.1.0","v8.19.0","v8.18.1"],"title":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges","number":213666,"url":"https://github.com/elastic/kibana/pull/213666","mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213666","number":213666,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2025
…or markdown with XL badges (#213666) (#213775) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)](#213666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T15:34:35Z","message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.18.0","v9.1.0","v8.19.0","v8.18.1"],"title":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges","number":213666,"url":"https://github.com/elastic/kibana/pull/213666","mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213666","number":213666,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges (#213666)\n\n### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges\n\nThis PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <https://github.com/elastic/kibana/issues/213228>.\n\nIt also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.\n\n\n\n#### Details\n\n- The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below:\n\n**Before**\n\n\n\n**After**\n\n\n\n- The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:\n\n**Before**\n\n\n\n**After**\n\n","sha":"ecdea5abaa2a2c318056e8474c0d513e9c6f535c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…kdown with XL badges (elastic#213666) ### [Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges This PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in <elastic#213228>. It also hides the `Load query` and `Save query` menu items from the filter popup menu in the settings flyout.  #### Details - The overflow issue is fixed by enabling horizontal scrolling when badges exceed the width of the markdown container, as illustrated by the before and after screenshots below: **Before**  **After**  - The`Load query` and `Save query` menu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below: **Before**  **After** 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Attack discovery] Fixes overflow styling for markdown with XL badges
This PR fixes an overflow styling issue when markdown contains badges that exceed the width of the container, as reported in #213228.
It also hides the
Load queryandSave querymenu items from the filter popup menu in the settings flyout.Details
Before
After
Load queryandSave querymenu items in the filter popup menu are now hidden, as illustrated by the before and after screenshots of the settings flyout below:Before
After