Skip to content

[ES|QL] Enables the timepicker if the time params are used with cast#215820

Merged
stratoula merged 2 commits intoelastic:mainfrom
stratoula:esql-support-time-params-cast
Mar 27, 2025
Merged

[ES|QL] Enables the timepicker if the time params are used with cast#215820
stratoula merged 2 commits intoelastic:mainfrom
stratoula:esql-support-time-params-cast

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 25, 2025 •
edited by kibanamachine
Loading

Summary

Closes #215366

Changes the utility to take under consideration the cast. (different representation in the ast tree)

image

Checklist
@stratoula stratoula added v9.1.0 v8.19.0 release_note:fix Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// backport:version Backport to applied version labels labels Mar 25, 2025
@stratoula stratoula marked this pull request as ready for review March 25, 2025 10:22
@stratoula stratoula requested a review from a team as a code owner March 25, 2025 10:22
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 25, 2025

Pinging @elastic/kibana-esql (Team:ESQL)
@stratoula stratoula changed the title [ES|QL] Retrieves the time field correctly if there is cast Mar 25, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 27, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-ast 249 253 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 542.5KB 542.6KB +78.0B
dataVisualizer 617.1KB 617.2KB +156.0B
discover 952.2KB 952.5KB +234.0B
investigateApp 189.9KB 190.0KB +78.0B
maps 3.0MB 3.0MB +78.0B
observabilityAIAssistantApp 264.9KB 265.0KB +78.0B
stackAlerts 73.3KB 73.3KB +78.0B
total +780.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-ast 27 26 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 58.6KB 58.7KB +78.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 313 317 +4

History
drewdaemon
drewdaemon approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems right.
@stratoula stratoula merged commit 61c64bc into elastic:main Mar 27, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 27, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14110630533
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 27, 2025
@stratoula
[ES|QL] Enables the timepicker if the time params are used with cast (e…
d34c762 
…lastic#215820)

## Summary

Closes elastic#215366

Changes the utility to take under consideration the cast. (different
representation in the ast tree)

<img width="1524" alt="image"
src="https://github.com/user-attachments/assets/a85571c3-2e71-4bc7-822b-3b44d77975e5"
/>

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 61c64bc)
@kibanamachine kibanamachine mentioned this pull request Mar 27, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 27, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request Mar 27, 2025
@kibanamachine @stratoula
[8.x] [ES|QL] Enables the timepicker if the time params are used with…
02a0ac0 
… cast (#215820) (#216198)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Enables the timepicker if the time params are used with cast
(#215820)](#215820)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-27T15:35:20Z","message":"[ES|QL]
Enables the timepicker if the time params are used with cast
(#215820)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/215366\n\nChanges the utility
to take under consideration the cast. (different\nrepresentation in the
ast tree)\n\n<img width=\"1524\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a85571c3-2e71-4bc7-822b-3b44d77975e5\"\n/>\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"61c64bcaee61e81d8ee68531cf7ba45e92aba975","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Enables the timepicker if the time params are used with
cast","number":215820,"url":"https://github.com/elastic/kibana/pull/215820","mergeCommit":{"message":"[ES|QL]
Enables the timepicker if the time params are used with cast
(#215820)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/215366\n\nChanges the utility
to take under consideration the cast. (different\nrepresentation in the
ast tree)\n\n<img width=\"1524\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a85571c3-2e71-4bc7-822b-3b44d77975e5\"\n/>\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"61c64bcaee61e81d8ee68531cf7ba45e92aba975"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215820","number":215820,"mergeCommit":{"message":"[ES|QL]
Enables the timepicker if the time params are used with cast
(#215820)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/215366\n\nChanges the utility
to take under consideration the cast. (different\nrepresentation in the
ast tree)\n\n<img width=\"1524\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a85571c3-2e71-4bc7-822b-3b44d77975e5\"\n/>\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"61c64bcaee61e81d8ee68531cf7ba45e92aba975"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
@stratoula @cqliu1
[ES|QL] Enables the timepicker if the time params are used with cast (e…
13e4bc8 
…lastic#215820)

## Summary

Closes elastic#215366

Changes the utility to take under consideration the cast. (different
representation in the ast tree)

<img width="1524" alt="image"
src="https://github.com/user-attachments/assets/a85571c3-2e71-4bc7-822b-3b44d77975e5"
/>


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

4 participants

@stratoula @elasticmachine @kibanamachine @drewdaemon