Skip to content

[ES|QL] Enables the timepicker if the time params are used with cast #215820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 2 commits into from
Mar 27, 2025
Merged

[ES|QL] Enables the timepicker if the time params are used with cast #215820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a6c6c
[ES|QL] Retrieves the time field correctly if there is cast
stratoula Mar 25, 2025
8e22d9a
Merge branch 'main' into esql-support-time-params-cast
stratoula Mar 27, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/platform/packages/shared/kbn-esql-ast/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export type {
AstProviderFn,
EditorError,
ESQLAstNode,
ESQLInlineCast,
} from './src/types';

export {
Expand Down
8 changes: 8 additions & 0 deletions src/platform/packages/shared/kbn-esql-utils/src/utils/query_parsing_helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@ describe('esql query helpers', () => {
)
).toBe('event.timefield');
});

it('should return the time field if the column is casted', () => {
expect(
getTimeFieldFromESQLQuery(
'from a | WHERE date_nanos::date >= ?_tstart AND date_nanos::date <= ?_tend'
)
).toBe('date_nanos');
});
});

describe('prettifyQuery', function () {
Expand Down
26 changes: 21 additions & 5 deletions src/platform/packages/shared/kbn-esql-utils/src/utils/query_parsing_helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import type {
ESQLFunction,
ESQLColumn,
ESQLSingleAstItem,
ESQLInlineCast,
ESQLCommandOption,
} from '@kbn/esql-ast';
import type { ESQLControlVariable } from '@kbn/esql-types';
Expand Down Expand Up @@ -100,12 +101,27 @@ export const getTimeFieldFromESQLQuery = (esql: string) => {
}
const lowLevelFunction = allFunctionsWithNamedParams[allFunctionsWithNamedParams.length - 1];

const column = lowLevelFunction.args.find((arg) => {
const argument = arg as ESQLSingleAstItem;
return argument.type === 'column';
}) as ESQLColumn;
let columnName: string | undefined;

return column?.name;
lowLevelFunction.args.some((arg) => {
const argument = arg as ESQLSingleAstItem | ESQLInlineCast<ESQLSingleAstItem>;
if (argument.type === 'column') {
columnName = argument.name;
return true;
}

if (
argument.type === 'inlineCast' &&
(argument as ESQLInlineCast<ESQLSingleAstItem>).value.type === 'column'
) {
columnName = (argument as ESQLInlineCast<ESQLSingleAstItem>).value.name;
return true;
}

return false;
});

return columnName;
};

export const isQueryWrappedByPipes = (query: string): boolean => {
Expand Down