Skip to content

[Spaces] Add defaultSolution to spaces config#218360

Merged
kowalczyk-krzysztof merged 3 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/add-defaultsolution-config-to-spaces
Apr 16, 2025
Merged

[Spaces] Add defaultSolution to spaces config#218360
kowalczyk-krzysztof merged 3 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/add-defaultsolution-config-to-spaces

Conversation

@kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Apr 15, 2025 •
edited
Loading

Summary

This PR adds new config option defaultSolution (xpack.spaces.defaultSolution) which lets you specify a default solution, similar to the way cloud plugin does it.

Closes: #213144
@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:enhancement Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature backport:version Backport to applied version labels v8.19.0 labels Apr 15, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Apr 15, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/add-defaultsolution-config-to-spaces branch from f4a685a to 158c3b4 Compare April 15, 2025 22:31
@azasypkin azasypkin mentioned this pull request Apr 16, 2025
Closed
@kowalczyk-krzysztof kowalczyk-krzysztof marked this pull request as ready for review April 16, 2025 11:21
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner April 16, 2025 11:21
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 16, 2025

Pinging @elastic/kibana-security (Team:Security)
@kc13greiner kc13greiner self-requested a review April 16, 2025 13:05
kc13greiner
kc13greiner requested changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage for the new property and condition
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 16, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @kowalczyk-krzysztof
kc13greiner
kc13greiner approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for the tests 🚀
@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 31f0f21 into elastic:main Apr 16, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 16, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14498690871
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 16, 2025
@kowalczyk-krzysztof
[Spaces] Add defaultSolution to spaces config (elastic#218360)
f2d83d3 
## Summary

This PR adds new config option `defaultSolution`
(`xpack.spaces.defaultSolution`) which lets you specify a default
solution, similar to the way cloud plugin does it.

Addresses: elastic#213144
(cherry picked from commit 31f0f21)
@kibanamachine kibanamachine mentioned this pull request Apr 16, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 16, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request Apr 16, 2025
@kibanamachine @kowalczyk-krzysztof
[8.x] [Spaces] Add defaultSolution to spaces config (#218360) (#218485)
ef1ea91 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Spaces] Add defaultSolution to spaces config
(#218360)](#218360)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-04-16T17:22:10Z","message":"[Spaces]
Add defaultSolution to spaces config (#218360)\n\n## Summary\n\nThis PR
adds new config option
`defaultSolution`\n(`xpack.spaces.defaultSolution`) which lets you
specify a default\nsolution, similar to the way cloud plugin does
it.\n\nAddresses:
#213144","sha":"31f0f211d9d76fc757adaff91e41f94bafbacfb4","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Security","enhancement","Feature:Security/Spaces","backport:version","v9.1.0","v8.19.0"],"title":"[Spaces]
Add defaultSolution to spaces
config","number":218360,"url":"https://github.com/elastic/kibana/pull/218360","mergeCommit":{"message":"[Spaces]
Add defaultSolution to spaces config (#218360)\n\n## Summary\n\nThis PR
adds new config option
`defaultSolution`\n(`xpack.spaces.defaultSolution`) which lets you
specify a default\nsolution, similar to the way cloud plugin does
it.\n\nAddresses:
#213144","sha":"31f0f211d9d76fc757adaff91e41f94bafbacfb4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218360","number":218360,"mergeCommit":{"message":"[Spaces]
Add defaultSolution to spaces config (#218360)\n\n## Summary\n\nThis PR
adds new config option
`defaultSolution`\n(`xpack.spaces.defaultSolution`) which lets you
specify a default\nsolution, similar to the way cloud plugin does
it.\n\nAddresses:
#213144","sha":"31f0f211d9d76fc757adaff91e41f94bafbacfb4"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Apr 17, 2025
@kowalczyk-krzysztof @akowalska622
[Spaces] Add defaultSolution to spaces config (elastic#218360)
682f41a 
## Summary

This PR adds new config option `defaultSolution`
(`xpack.spaces.defaultSolution`) which lets you specify a default
solution, similar to the way cloud plugin does it.

Addresses: elastic#213144
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@kowalczyk-krzysztof @akowalska622
[Spaces] Add defaultSolution to spaces config (elastic#218360)
c041437 
## Summary

This PR adds new config option `defaultSolution`
(`xpack.spaces.defaultSolution`) which lets you specify a default
solution, similar to the way cloud plugin does it.

Addresses: elastic#213144
@florent-leborgne florent-leborgne mentioned this pull request Jun 10, 2025
Closed
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the feat/add-defaultsolution-config-to-spaces branch August 1, 2025 12:28
@ezimuel
Copy link
Contributor

ezimuel commented Sep 26, 2025

@kowalczyk-krzysztof can I set the also xpack.spaces.defaultSolution as ENV variable for Kibana in Docker?
I'm trying to use this settings but it doesn't seem working:

kibana:
    image: docker.elastic.co/kibana/kibana:9.1.4
    container_name: test_kibana
    volumes:
      - dev-kibana:/usr/share/kibana/data
    ports:
      - 127.0.0.1:5601:5601
    environment:
      - SERVER_NAME=kibana
      - ELASTICSEARCH_HOSTS=http://elasticsearch:9200
      - XPACK_SPACES_DEFAULTSOLUTION=oblt

Thanks!
@ezimuel
Copy link
Contributor

ezimuel commented Sep 26, 2025

@kowalczyk-krzysztof I just found that xpack.spaces.defaultSolution is not present in this list.
@kowalczyk-krzysztof
Copy link
Member Author

kowalczyk-krzysztof commented Sep 26, 2025 •
edited
Loading

@ezimuel When we add new values to Kibana config, we do that in Kibana code itself and sometimes we add it to Cloud whitelist if it's meant to be available on ECH.

I'm not sure why it's not available in Docker. Probably best to reach out to people who maintain the dockerfiles repository.
@legrego
Copy link
Member

legrego commented Sep 26, 2025

I've raised #236570 to address this.
@kowalczyk-krzysztof
Copy link
Member Author

kowalczyk-krzysztof commented Sep 26, 2025

Thanks for handling this @legrego! This is new to me, I'll make sure to remember about this step when adding new configs.
@ezimuel
Copy link
Contributor

ezimuel commented Sep 26, 2025

Thanks @kowalczyk-krzysztof and @legrego
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature release_note:enhancement Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.19.0 v9.1.0

6 participants

@kowalczyk-krzysztof @elasticmachine @kibanamachine @ezimuel @legrego @kc13greiner