Skip to content

[TSVB/SCSS] Migrate timeseries_visualization.scss file#221094

Merged
mariairiartef merged 3 commits intoelastic:mainfrom
mariairiartef:tsvb/scss-js/timeseries_visualization
May 29, 2025
Merged

[TSVB/SCSS] Migrate timeseries_visualization.scss file#221094
mariairiartef merged 3 commits intoelastic:mainfrom
mariairiartef:tsvb/scss-js/timeseries_visualization

Conversation

@mariairiartef
Copy link
Contributor

@mariairiartef mariairiartef commented May 21, 2025

Summary

Part of #220095

Migrates timeseries_visualization.scss file.

Considerations

For details on considerations, read this.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
@mariairiartef mariairiartef self-assigned this May 21, 2025
@mariairiartef mariairiartef added Feature:TSVB TSVB (Time Series Visual Builder) technical debt Improvement of the software architecture and operational architecture Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting scss-removal labels May 21, 2025
@mariairiartef mariairiartef added backport:version Backport to applied version labels v9.1.0 v8.19.0 and removed backport:skip This PR does not require backporting labels May 27, 2025
@mariairiartef mariairiartef marked this pull request as ready for review May 27, 2025 10:02
@mariairiartef mariairiartef requested review from a team as code owners May 27, 2025 10:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 489 484 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 472.0KB 470.9KB -1.1KB

cc @mariairiartef

@mariairiartef mariairiartef enabled auto-merge (squash) May 29, 2025 10:51
@mariairiartef mariairiartef merged commit 7ed6ae8 into elastic:main May 29, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15324282565

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 2, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 221094 locally
cc: @mariairiartef

mariairiartef added a commit to mariairiartef/kibana that referenced this pull request Jun 3, 2025
)

## Summary

Part of elastic#220095

Migrates `timeseries_visualization.scss` file.

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

## Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 7ed6ae8)

# Conflicts:
#	src/platform/plugins/private/vis_types/timeseries/public/application/components/timeseries_visualization.scss
@mariairiartef
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mariairiartef

mariairiartef added a commit that referenced this pull request Jun 3, 2025
) (#222359)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[TSVB/SCSS] Migrate `timeseries_visualization.scss` file
(#221094)](#221094)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maria
Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-29T12:52:40Z","message":"[TSVB/SCSS]
Migrate `timeseries_visualization.scss` file (#221094)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/220095\n\nMigrates
`timeseries_visualization.scss` file.\n\n### Considerations\n\nFor
details on considerations,
read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n##
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7ed6ae863a5c1983049798f202552fad2bb7dc76","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","technical
debt","Team:Visualizations","release_note:skip","backport
missing","backport:version","v9.1.0","v8.19.0","scss-removal"],"title":"[TSVB/SCSS]
Migrate `timeseries_visualization.scss`
file","number":221094,"url":"https://github.com/elastic/kibana/pull/221094","mergeCommit":{"message":"[TSVB/SCSS]
Migrate `timeseries_visualization.scss` file (#221094)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/220095\n\nMigrates
`timeseries_visualization.scss` file.\n\n### Considerations\n\nFor
details on considerations,
read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n##
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7ed6ae863a5c1983049798f202552fad2bb7dc76"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221094","number":221094,"mergeCommit":{"message":"[TSVB/SCSS]
Migrate `timeseries_visualization.scss` file (#221094)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/220095\n\nMigrates
`timeseries_visualization.scss` file.\n\n### Considerations\n\nFor
details on considerations,
read\n[this](https://github.com/elastic/kibana/issues/220095#issuecomment-2911737679).\n\n##
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7ed6ae863a5c1983049798f202552fad2bb7dc76"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 3, 2025
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
)

## Summary

Part of elastic#220095

Migrates `timeseries_visualization.scss` file.

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

## Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
)

## Summary

Part of elastic#220095

Migrates `timeseries_visualization.scss` file.

### Considerations

For details on considerations, read
[this](elastic#220095 (comment)).

## Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes scss-removal Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// technical debt Improvement of the software architecture and operational architecture v8.19.0 v9.1.0

5 participants