[Discover] Show ES|QL request URL in Inpector flyout#221816
Merged
jughosta merged 1 commit intoelastic:mainfrom May 29, 2025
Merged
[Discover] Show ES|QL request URL in Inpector flyout#221816jughosta merged 1 commit intoelastic:mainfrom
jughosta merged 1 commit intoelastic:mainfrom
Conversation
jughosta
added
v9.0.0
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
markov00
approved these changes
May 29, 2025
AlexGPlay
approved these changes
May 29, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 29, 2025
- Closes elastic#221581 ## Summary This PR adds the missing `requestParams` to the search interceptor code. This makes the request URL appear again in Inpector flyout (Request tab). <img width="1072" alt="Screenshot 2025-05-28 at 17 55 09" src="https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 7fae9c5)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 29, 2025
…221893) # Backport This will backport the following commits from `main` to `9.0`: - [[Discover] Show ES|QL request URL in Inpector flyout (#221816)](#221816) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T08:30:13Z","message":"[Discover] Show ES|QL request URL in Inpector flyout (#221816)\n\n- Closes https://github.com/elastic/kibana/issues/221581\n\n## Summary\n\nThis PR adds the missing `requestParams` to the search interceptor code.\nThis makes the request URL appear again in Inpector flyout (Request\ntab).\n\n<img width=\"1072\" alt=\"Screenshot 2025-05-28 at 17 55 09\"\nsrc=\"https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7fae9c5d6e86a588f6657dabe6894519449a03ad","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","Feature:ES|QL","backport:version","v9.1.0","v8.19.0"],"title":"[Discover] Show ES|QL request URL in Inpector flyout","number":221816,"url":"https://github.com/elastic/kibana/pull/221816","mergeCommit":{"message":"[Discover] Show ES|QL request URL in Inpector flyout (#221816)\n\n- Closes https://github.com/elastic/kibana/issues/221581\n\n## Summary\n\nThis PR adds the missing `requestParams` to the search interceptor code.\nThis makes the request URL appear again in Inpector flyout (Request\ntab).\n\n<img width=\"1072\" alt=\"Screenshot 2025-05-28 at 17 55 09\"\nsrc=\"https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7fae9c5d6e86a588f6657dabe6894519449a03ad"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221816","number":221816,"mergeCommit":{"message":"[Discover] Show ES|QL request URL in Inpector flyout (#221816)\n\n- Closes https://github.com/elastic/kibana/issues/221581\n\n## Summary\n\nThis PR adds the missing `requestParams` to the search interceptor code.\nThis makes the request URL appear again in Inpector flyout (Request\ntab).\n\n<img width=\"1072\" alt=\"Screenshot 2025-05-28 at 17 55 09\"\nsrc=\"https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7fae9c5d6e86a588f6657dabe6894519449a03ad"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
1 task
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
- Closes elastic#221581 ## Summary This PR adds the missing `requestParams` to the search interceptor code. This makes the request URL appear again in Inpector flyout (Request tab). <img width="1072" alt="Screenshot 2025-05-28 at 17 55 09" src="https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This was referenced May 29, 2025
This was referenced May 29, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
May 30, 2025
- Closes elastic#221581 ## Summary This PR adds the missing `requestParams` to the search interceptor code. This makes the request URL appear again in Inpector flyout (Request tab). <img width="1072" alt="Screenshot 2025-05-28 at 17 55 09" src="https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 7fae9c5) # Conflicts: # src/platform/plugins/shared/data/public/search/search_interceptor/search_interceptor.ts
jughosta
added a commit
that referenced
this pull request
May 30, 2025
…#222004) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Show ES|QL request URL in Inpector flyout (#221816)](#221816) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T08:30:13Z","message":"[Discover] Show ES|QL request URL in Inpector flyout (#221816)\n\n- Closes https://github.com/elastic/kibana/issues/221581\n\n## Summary\n\nThis PR adds the missing `requestParams` to the search interceptor code.\nThis makes the request URL appear again in Inpector flyout (Request\ntab).\n\n<img width=\"1072\" alt=\"Screenshot 2025-05-28 at 17 55 09\"\nsrc=\"https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7fae9c5d6e86a588f6657dabe6894519449a03ad","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","Feature:ES|QL","backport:version","v9.1.0","v8.19.0","v9.0.2"],"title":"[Discover] Show ES|QL request URL in Inpector flyout","number":221816,"url":"https://github.com/elastic/kibana/pull/221816","mergeCommit":{"message":"[Discover] Show ES|QL request URL in Inpector flyout (#221816)\n\n- Closes https://github.com/elastic/kibana/issues/221581\n\n## Summary\n\nThis PR adds the missing `requestParams` to the search interceptor code.\nThis makes the request URL appear again in Inpector flyout (Request\ntab).\n\n<img width=\"1072\" alt=\"Screenshot 2025-05-28 at 17 55 09\"\nsrc=\"https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7fae9c5d6e86a588f6657dabe6894519449a03ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/221893","number":221893,"state":"MERGED","mergeCommit":{"sha":"ea2ff4db67d05650312ce4974285c3d6cb7593c7","message":"[9.0] [Discover] Show ES|QL request URL in Inpector flyout (#221816) (#221893)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Discover] Show ES|QL request URL in Inpector flyout\n(#221816)](https://github.com/elastic/kibana/pull/221816)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221816","number":221816,"mergeCommit":{"message":"[Discover] Show ES|QL request URL in Inpector flyout (#221816)\n\n- Closes https://github.com/elastic/kibana/issues/221581\n\n## Summary\n\nThis PR adds the missing `requestParams` to the search interceptor code.\nThis makes the request URL appear again in Inpector flyout (Request\ntab).\n\n<img width=\"1072\" alt=\"Screenshot 2025-05-28 at 17 55 09\"\nsrc=\"https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7\"\n/>\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7fae9c5d6e86a588f6657dabe6894519449a03ad"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Contributor
|
This PR didn't make it into the latest 9.0.2 BC. Updating the labels. |
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
- Closes elastic#221581 ## Summary This PR adds the missing `requestParams` to the search interceptor code. This makes the request URL appear again in Inpector flyout (Request tab). <img width="1072" alt="Screenshot 2025-05-28 at 17 55 09" src="https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
- Closes elastic#221581 ## Summary This PR adds the missing `requestParams` to the search interceptor code. This makes the request URL appear again in Inpector flyout (Request tab). <img width="1072" alt="Screenshot 2025-05-28 at 17 55 09" src="https://github.com/user-attachments/assets/1c11c7d7-1e49-4265-a014-88f369dad2a7" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing
requestParamsto the search interceptor code. This makes the request URL appear again in Inpector flyout (Request tab).Checklist
release_note:*label is applied per the guidelines