[ES|QL] fix suggestions after triple quote pair#221200
Merged
drewdaemon merged 29 commits intoelastic:mainfrom May 22, 2025
Merged
[ES|QL] fix suggestions after triple quote pair#221200drewdaemon merged 29 commits intoelastic:mainfrom
drewdaemon merged 29 commits intoelastic:mainfrom
Conversation
drewdaemon
commented
May 21, 2025
Comment on lines
-719
to
+724
| if (substr === openBracket) { | ||
| stack.push(substr); | ||
| break; | ||
| } else if (pairsReversed[substr] && pairsReversed[substr] === stack[stack.length - 1]) { | ||
| if (pairsReversed[substr] && pairsReversed[substr] === stack[stack.length - 1]) { | ||
| stack.pop(); | ||
| break; | ||
| } else if (substr === openBracket) { | ||
| stack.push(substr); | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
This needed to be reversed. """ is a symmetric token (both opening and closing) so the algo needs to check whether one has already been seen at the corresponding level to know how to interpret it.
Contributor
💚 Build Succeeded
Metrics [docs]
|
drewdaemon
added
release_note:fix
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 22, 2025
## Summary fix elastic#221073 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 933bff1)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 22, 2025
…1273) # Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] fix suggestions after triple quote pair (#221200)](#221200) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-05-22T14:59:24Z","message":"[ES|QL] fix suggestions after triple quote pair (#221200)\n\n## Summary\n\nfix https://github.com/elastic/kibana/issues/221073\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"933bff12a601fcb4868e0c76f002ff381b4234cc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] fix suggestions after triple quote pair","number":221200,"url":"https://github.com/elastic/kibana/pull/221200","mergeCommit":{"message":"[ES|QL] fix suggestions after triple quote pair (#221200)\n\n## Summary\n\nfix https://github.com/elastic/kibana/issues/221073\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"933bff12a601fcb4868e0c76f002ff381b4234cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221200","number":221200,"mergeCommit":{"message":"[ES|QL] fix suggestions after triple quote pair (#221200)\n\n## Summary\n\nfix https://github.com/elastic/kibana/issues/221073\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"933bff12a601fcb4868e0c76f002ff381b4234cc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary fix elastic#221073 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #221073
Checklist