-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ES|QL] fix suggestions after triple quote pair #221200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drewdaemon
merged 29 commits into
elastic:main
from
drewdaemon:221073/wrong-suggestions-after-stats-where
May 22, 2025
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0e937a9
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 7ffbf4c
Merge branch 'main' of github.com:elastic/kibana
drewdaemon b426318
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 511ccaa
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 2d71300
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 0076de9
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 2898ce1
Merge branch 'main' of github.com:elastic/kibana
drewdaemon ace0009
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 6cdd8c1
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 98616e9
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 64e40fd
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 1e3f8d1
Merge branch 'main' of github.com:elastic/kibana
drewdaemon afd5630
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 31c6cb3
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 08f4b1b
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 0c11f55
Merge branch 'main' of github.com:elastic/kibana
drewdaemon de2bc7a
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 828d142
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 34bd1ef
Merge branch 'main' of github.com:elastic/kibana
drewdaemon f0070c6
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 16a27c7
Merge branch 'main' of github.com:elastic/kibana
drewdaemon cde697e
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 8b66178
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 3555b0c
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 57a5f4a
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 420eb2b
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 8e5e4a8
Merge branch 'main' of github.com:elastic/kibana
drewdaemon 141765f
Merge branch 'main' of github.com:elastic/kibana
drewdaemon ba39f6c
fix pair detection
drewdaemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needed to be reversed.
"""is a symmetric token (both opening and closing) so the algo needs to check whether one has already been seen at the corresponding level to know how to interpret it.