Skip to content

[ES|QL] Adds shortcuts in the editor#221331

Merged
stratoula merged 10 commits intoelastic:mainfrom
stratoula:esql-editor-shortcuts
May 26, 2025
Merged

[ES|QL] Adds shortcuts in the editor#221331
stratoula merged 10 commits intoelastic:mainfrom
stratoula:esql-editor-shortcuts

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented May 23, 2025 •
edited by kibanamachine
Loading

Summary

Closes #214540

Removes the shortcuts from the Unified search component (I did some additional cleaning too) and adds it as a button in the editor.

image image image

Removed the shortcut from the tooltip and button

image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.
@l-suarez
Copy link
Contributor

l-suarez commented May 23, 2025

Thanks @stratoula, it looks great! And you're right, let's update the button to primary to follow the same color scheme.
@stratoula stratoula added v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// backport:version Backport to applied version labels labels May 23, 2025
@stratoula stratoula changed the title [ES|QL] Removes the shortcut from the aria-label May 23, 2025
@stratoula stratoula marked this pull request as ready for review May 23, 2025 09:48
@stratoula stratoula requested review from a team as code owners May 23, 2025 09:48
@elasticmachine
Copy link
Contributor

elasticmachine commented May 23, 2025

Pinging @elastic/kibana-esql (Team:ESQL)
@stratoula
Copy link
Contributor Author

stratoula commented May 23, 2025

@l-suarez thanx, done! 94d9cb2
drewdaemon
drewdaemon approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice start!
@elasticmachine
Copy link
Contributor

elasticmachine commented May 26, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Cypress Tests #3 / Pagination Host uncommon processes table) pagination resets results and page number to first page when refresh is clicked pagination resets results and page number to first page when refresh is clicked
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #1 / Pagination Host uncommon processes table) pagination resets results and page number to first page when refresh is clicked pagination resets results and page number to first page when refresh is clicked

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esql 202 203 +1
lens 1624 1625 +1
stackAlerts 256 257 +1
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 250.5KB 252.1KB +1.6KB
unifiedSearch 352.7KB 352.4KB -296.0B
total +1.3KB

History
ThomThomson
ThomThomson approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested this locally and made sure shortcuts still work in data views & ESQL modes.
@stratoula stratoula merged commit 543a7b6 into elastic:main May 26, 2025
9 of 10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented May 26, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15257657033
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 26, 2025
@stratoula
[ES|QL] Adds shortcuts in the editor (elastic#221331)
f8f7a59 
## Summary

Closes elastic#214540

Removes the shortcuts from the Unified search component (I did some
additional cleaning too) and adds it as a button in the editor.

<img width="952" alt="image"
src="https://github.com/user-attachments/assets/c1038c89-09fe-4d27-8884-267aa2abadea"
/>

<img width="426" alt="image"
src="https://github.com/user-attachments/assets/0ef1aed6-bdc6-4564-9892-02addbcbc114"
/>

<img width="439" alt="image"
src="https://github.com/user-attachments/assets/69276b58-2651-4130-9136-ed9246e5787f"
/>

Removed the shortcut from the tooltip and button

<img width="669" alt="image"
src="https://github.com/user-attachments/assets/2d28c82c-9f0f-43d2-a2fc-a13a77bdfafc"
/>

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)

(cherry picked from commit 543a7b6)
@kibanamachine kibanamachine mentioned this pull request May 26, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented May 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request May 26, 2025
@kibanamachine @stratoula
[8.19] [ES|QL] Adds shortcuts in the editor (#221331) (#221534)
11993e5 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Adds shortcuts in the editor
(#221331)](#221331)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-05-26T15:37:05Z","message":"[ES|QL]
Adds shortcuts in the editor (#221331)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/214540\n\nRemoves the shortcuts
from the Unified search component (I did some\nadditional cleaning too)
and adds it as a button in the editor.\n\n<img width=\"952\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c1038c89-09fe-4d27-8884-267aa2abadea\"\n/>\n\n<img
width=\"426\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/0ef1aed6-bdc6-4564-9892-02addbcbc114\"\n/>\n\n<img
width=\"439\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/69276b58-2651-4130-9136-ed9246e5787f\"\n/>\n\n\nRemoved
the shortcut from the tooltip and button\n\n<img width=\"669\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2d28c82c-9f0f-43d2-a2fc-a13a77bdfafc\"\n/>\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)","sha":"543a7b6981b281e2efe9e1b8ea2ec2f6d7c3dca0","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Adds shortcuts in the
editor","number":221331,"url":"https://github.com/elastic/kibana/pull/221331","mergeCommit":{"message":"[ES|QL]
Adds shortcuts in the editor (#221331)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/214540\n\nRemoves the shortcuts
from the Unified search component (I did some\nadditional cleaning too)
and adds it as a button in the editor.\n\n<img width=\"952\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c1038c89-09fe-4d27-8884-267aa2abadea\"\n/>\n\n<img
width=\"426\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/0ef1aed6-bdc6-4564-9892-02addbcbc114\"\n/>\n\n<img
width=\"439\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/69276b58-2651-4130-9136-ed9246e5787f\"\n/>\n\n\nRemoved
the shortcut from the tooltip and button\n\n<img width=\"669\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2d28c82c-9f0f-43d2-a2fc-a13a77bdfafc\"\n/>\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)","sha":"543a7b6981b281e2efe9e1b8ea2ec2f6d7c3dca0"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221331","number":221331,"mergeCommit":{"message":"[ES|QL]
Adds shortcuts in the editor (#221331)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/214540\n\nRemoves the shortcuts
from the Unified search component (I did some\nadditional cleaning too)
and adds it as a button in the editor.\n\n<img width=\"952\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c1038c89-09fe-4d27-8884-267aa2abadea\"\n/>\n\n<img
width=\"426\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/0ef1aed6-bdc6-4564-9892-02addbcbc114\"\n/>\n\n<img
width=\"439\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/69276b58-2651-4130-9136-ed9246e5787f\"\n/>\n\n\nRemoved
the shortcut from the tooltip and button\n\n<img width=\"669\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2d28c82c-9f0f-43d2-a2fc-a13a77bdfafc\"\n/>\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)","sha":"543a7b6981b281e2efe9e1b8ea2ec2f6d7c3dca0"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@stratoula @akowalska622
[ES|QL] Adds shortcuts in the editor (elastic#221331)
d2f4c2a 
## Summary

Closes elastic#214540

Removes the shortcuts from the Unified search component (I did some
additional cleaning too) and adds it as a button in the editor.

<img width="952" alt="image"
src="https://github.com/user-attachments/assets/c1038c89-09fe-4d27-8884-267aa2abadea"
/>

<img width="426" alt="image"
src="https://github.com/user-attachments/assets/0ef1aed6-bdc6-4564-9892-02addbcbc114"
/>

<img width="439" alt="image"
src="https://github.com/user-attachments/assets/69276b58-2651-4130-9136-ed9246e5787f"
/>


Removed the shortcut from the tooltip and button

<img width="669" alt="image"
src="https://github.com/user-attachments/assets/2d28c82c-9f0f-43d2-a2fc-a13a77bdfafc"
/>


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
@alexwizp alexwizp mentioned this pull request May 29, 2025
Closed
@florent-leborgne florent-leborgne mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

6 participants

@stratoula @l-suarez @elasticmachine @kibanamachine @drewdaemon @ThomThomson