Skip to content

[8.19] [ES|QL] Adds shortcuts in the editor (#221331)#221534

Merged
kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine:backport/8.19/pr-221331
May 26, 2025
Merged

[8.19] [ES|QL] Adds shortcuts in the editor (#221331)#221534
kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine:backport/8.19/pr-221331

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Closes elastic#214540

Removes the shortcuts from the Unified search component (I did some
additional cleaning too) and adds it as a button in the editor.

<img width="952" alt="image"
src="https://github.com/user-attachments/assets/c1038c89-09fe-4d27-8884-267aa2abadea"
/>

<img width="426" alt="image"
src="https://github.com/user-attachments/assets/0ef1aed6-bdc6-4564-9892-02addbcbc114"
/>

<img width="439" alt="image"
src="https://github.com/user-attachments/assets/69276b58-2651-4130-9136-ed9246e5787f"
/>

Removed the shortcut from the tooltip and button

<img width="669" alt="image"
src="https://github.com/user-attachments/assets/2d28c82c-9f0f-43d2-a2fc-a13a77bdfafc"
/>

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)

(cherry picked from commit 543a7b6)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 26, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) May 26, 2025 15:44
@kibanamachine kibanamachine merged commit 11993e5 into elastic:8.19 May 26, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / Synthetics API Tests SyncGlobalParams parsed params for previously added http monitors

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esql 201 202 +1
lens 1581 1582 +1
stackAlerts 249 250 +1
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 246.0KB 247.6KB +1.6KB
unifiedSearch 349.9KB 349.6KB -296.0B
total +1.3KB

cc @stratoula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

3 participants