[Ingest Pipelines] Fix handling special symbols from navigation#233651
Merged
kapral18 merged 6 commits intoelastic:mainfrom Sep 11, 2025
Merged
Conversation
kapral18
force-pushed
the
fix/ingest-pipelines/decode-non-existent-pipeline-name
branch
2 times, most recently
from
8e83eb8 to
eb2d896
Compare
kapral18
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
kapral18
force-pushed
the
fix/ingest-pipelines/decode-non-existent-pipeline-name
branch
from
eb2d896 to
248a941
Compare
ElenaStoeva
approved these changes
Sep 1, 2025
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for working on this @kapral18! Tested locally and it works well, changes also lgtm.
kapral18
force-pushed
the
fix/ingest-pipelines/decode-non-existent-pipeline-name
branch
from
248a941 to
7690906
Compare
kapral18
changed the title
kapral18
added
release_note:fix
and removed
release_note:skip
kapral18
added
bug
sabarasaba
reviewed
Sep 5, 2025
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this and adding the much needed tests! Left a few comments, let me know what you think
...gins/shared/ingest_pipelines/public/application/sections/pipelines_clone/pipelines_clone.tsx
Outdated
Show resolved
Hide resolved
...shared/ingest_pipelines/public/application/sections/pipelines_clone/pipelines_clone.test.tsx
Outdated
Show resolved
Hide resolved
...ared/ingest_pipelines/public/application/sections/pipelines_create/pipelines_create.test.tsx
Outdated
Show resolved
Hide resolved
...platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
Outdated
Show resolved
Hide resolved
kapral18
force-pushed
the
fix/ingest-pipelines/decode-non-existent-pipeline-name
branch
from
1031e75 to
01f2290
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix ingest pipelines edit/clone tests by keeping window.location mock in sync with MemoryRouter initialEntries
kapral18
force-pushed
the
fix/ingest-pipelines/decode-non-existent-pipeline-name
branch
from
468fe26 to
75acaf9
Compare
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @kapral18 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kapral18
deleted the
fix/ingest-pipelines/decode-non-existent-pipeline-name
branch
This was referenced Sep 11, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Sep 11, 2025
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 24ae4db) # Conflicts: # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_clone.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_edit.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_edit/pipelines_edit.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Sep 11, 2025
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 24ae4db) # Conflicts: # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_clone.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_edit.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_edit/pipelines_edit.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Sep 11, 2025
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 24ae4db) # Conflicts: # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_clone.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_edit.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_edit/pipelines_edit.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Sep 11, 2025
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 24ae4db) # Conflicts: # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_clone.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_edit.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_edit/pipelines_edit.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
kapral18
added a commit
that referenced
this pull request
Sep 12, 2025
…#233651) (#234799) # Backport This will backport the following commits from `main` to `9.0`: - [[Ingest Pipelines] Fix handling special symbols from navigation (#233651)](#233651) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-09-11T12:58:25Z","message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Kibana Management","Feature:Ingest Node Pipelines","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Ingest Pipelines] Fix handling special symbols from navigation","number":233651,"url":"https://github.com/elastic/kibana/pull/233651","mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/233651","number":233651,"mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kapral18
added a commit
that referenced
this pull request
Sep 12, 2025
#233651) (#234800) # Backport This will backport the following commits from `main` to `8.19`: - [[Ingest Pipelines] Fix handling special symbols from navigation (#233651)](#233651) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-09-11T12:58:25Z","message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Kibana Management","Feature:Ingest Node Pipelines","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Ingest Pipelines] Fix handling special symbols from navigation","number":233651,"url":"https://github.com/elastic/kibana/pull/233651","mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/233651","number":233651,"mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kapral18
added a commit
that referenced
this pull request
Sep 12, 2025
#233651) (#234801) # Backport This will backport the following commits from `main` to `8.18`: - [[Ingest Pipelines] Fix handling special symbols from navigation (#233651)](#233651) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-09-11T12:58:25Z","message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Kibana Management","Feature:Ingest Node Pipelines","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Ingest Pipelines] Fix handling special symbols from navigation","number":233651,"url":"https://github.com/elastic/kibana/pull/233651","mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/233651","number":233651,"mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kapral18
added a commit
that referenced
this pull request
Sep 12, 2025
…#233651) (#234798) # Backport This will backport the following commits from `main` to `9.1`: - [[Ingest Pipelines] Fix handling special symbols from navigation (#233651)](#233651) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-09-11T12:58:25Z","message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Kibana Management","Feature:Ingest Node Pipelines","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Ingest Pipelines] Fix handling special symbols from navigation","number":233651,"url":"https://github.com/elastic/kibana/pull/233651","mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/233651","number":233651,"mergeCommit":{"message":"[Ingest Pipelines] Fix handling special symbols from navigation (#233651)\n\nfixes #230536\n\nThis pull request fixes encoding behavior and adds comprehensive test\ncoverage for the ingest pipelines create, clone, and edit sections,\nfocusing on robust handling of pipeline names with special characters\nand addressing known issues with URL encoding/decoding in [history\nv4](remix-run/history#786) fixed in next\nversion of react-router(6+).\n\n## Impacted flows\n\n### Before fix\n\n1. Creating a non-existent pipeline from not-found Flyout, containing\nspecial symbols. (main issue)\n<img width=\"1540\" height=\"1304\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee\"\n/>\n\n2. Editing pipeline containing special symbols in the name -> Reloading\nedit form (newly discovered issue)\n<img width=\"1531\" height=\"1349\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071\"\n/>\n\n3. Cloning pipeline containing special symbols in the name -> Reloading\nclone form (newly discovered issue)\n<img width=\"1548\" height=\"1367\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8\"\n/>\n\n### After fix\n\n\nhttps://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410\n\n\nhttps://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6\n\n\nhttps://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c\n\n## How to test\n\n### Unknown pipeline creation case\n\n1. Open a flyout for a non-existing test@custom pipeline (e.g. by\nnavigating to\n`/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and\nclick on \"Create\" button.\n2. See pipeline name correctly showing `test@custom` (instead of\n`test%40custom`)\n\n### Edit page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `Edit pipeline` button\n4. When edit page is loaded, reload the page\n5. See no more error happening\n\n### Clone page reload with special symbols case\n\n1. Go to `/app/management/ingest/ingest_pipelines/create`\n2. Crete pipeline with name `asd!@#$ asd%^&`\n3. In the opened flyout on the bottom click `...` button\n4. Click duplicate page\n5. When the form is loaded, reload the page\n6. See no more error happening\n\n## Release Note\n\n- fix special symbols handling when creating new pipeline from flyout\n- fix edit page crash upon reload, for pipeline that has special symbols\nin the name\n- fix clone page error upon reload, for pipeline that has special\nsymbols in the name\n\n---------\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>","sha":"24ae4db5e990e62e3e716d0807772c996b47ec50"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
) fixes #230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #230536
This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in history v4 fixed in next version of react-router(6+).
Impacted flows
Before fix
After fix
Screen.Recording.2025-09-01.at.16.51.mp4
Screen.Recording.2025-09-04.at.23.02.mp4
Screen.Recording.2025-09-04.at.23.03.mp4
How to test
Unknown pipeline creation case
/app/management/ingest/ingest_pipelines?pipeline=test@custom) and click on "Create" button.test@custom(instead oftest%40custom)Edit page reload with special symbols case
/app/management/ingest/ingest_pipelines/createasd!@#$ asd%^&Edit pipelinebuttonClone page reload with special symbols case
/app/management/ingest/ingest_pipelines/createasd!@#$ asd%^&...buttonRelease Note