[8.19] [Ingest Pipelines] Fix handling special symbols from navigation (#233651)#234800
Merged
kapral18 merged 2 commits intoelastic:8.19from Sep 12, 2025
Merged
[8.19] [Ingest Pipelines] Fix handling special symbols from navigation (#233651)#234800kapral18 merged 2 commits intoelastic:8.19from
kapral18 merged 2 commits intoelastic:8.19from
Conversation
…tic#233651) fixes elastic#230536 This pull request fixes encoding behavior and adds comprehensive test coverage for the ingest pipelines create, clone, and edit sections, focusing on robust handling of pipeline names with special characters and addressing known issues with URL encoding/decoding in [history v4](remix-run/history#786) fixed in next version of react-router(6+). ## Impacted flows ### Before fix 1. Creating a non-existent pipeline from not-found Flyout, containing special symbols. (main issue) <img width="1540" height="1304" alt="image" src="https://github.com/user-attachments/assets/ddc44615-c74d-4021-89bd-6cfc48e6d0ee" /> 2. Editing pipeline containing special symbols in the name -> Reloading edit form (newly discovered issue) <img width="1531" height="1349" alt="image" src="https://github.com/user-attachments/assets/3c1de15f-9f8e-496e-bf08-17dab5753071" /> 3. Cloning pipeline containing special symbols in the name -> Reloading clone form (newly discovered issue) <img width="1548" height="1367" alt="image" src="https://github.com/user-attachments/assets/cff608ce-e921-46c7-b1ad-989dc9f6f0c8" /> ### After fix https://github.com/user-attachments/assets/60f4ab29-0c57-4533-b05f-765b1b546410 https://github.com/user-attachments/assets/3bd37ef1-a60c-4350-b597-027dc6ac6da6 https://github.com/user-attachments/assets/9d1e847e-3694-4e23-9089-837ba603540c ## How to test ### Unknown pipeline creation case 1. Open a flyout for a non-existing test@custom pipeline (e.g. by navigating to `/app/management/ingest/ingest_pipelines?pipeline=test@custom`) and click on "Create" button. 2. See pipeline name correctly showing `test@custom` (instead of `test%40custom`) ### Edit page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `Edit pipeline` button 4. When edit page is loaded, reload the page 5. See no more error happening ### Clone page reload with special symbols case 1. Go to `/app/management/ingest/ingest_pipelines/create` 2. Crete pipeline with name `asd!@#$ asd%^&` 3. In the opened flyout on the bottom click `...` button 4. Click duplicate page 5. When the form is loaded, reload the page 6. See no more error happening ## Release Note - fix special symbols handling when creating new pipeline from flyout - fix edit page crash upon reload, for pipeline that has special symbols in the name - fix clone page error upon reload, for pipeline that has special symbols in the name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 24ae4db) # Conflicts: # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_clone.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_edit.test.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_edit/pipelines_edit.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
damian-polewski
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation