[Lens] [Metric chart] Update appearance popover#233992
Merged
mariairiartef merged 5 commits intoelastic:mainfrom Sep 10, 2025
Merged
[Lens] [Metric chart] Update appearance popover#233992mariairiartef merged 5 commits intoelastic:mainfrom
mariairiartef merged 5 commits intoelastic:mainfrom
Conversation
mariairiartef
added
Team:Visualizations
mariairiartef
force-pushed
the
lens/233702
branch
from
fba9865 to
32ae1a3
Compare
mariairiartef
force-pushed
the
lens/233702
branch
from
32ae1a3 to
9029b37
Compare
mariairiartef
force-pushed
the
lens/233702
branch
from
9029b37 to
fe50233
Compare
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
reviewed
Sep 4, 2025
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the metric chart visualization's toolbar popover to improve its appearance and functionality. The main change is renaming the "Titles and text" popover to "Appearance" and restructuring it to show all settings with appropriate disabled states for unavailable options.
Key Changes
- Replaced the "Titles and text" popover with a new "Appearance" popover
- Reorganized settings into logical groups (Primary metric, Title and subtitle, Secondary metric, Other)
- Added disabled states for subtitle, secondary metric alignment, and icon position when not applicable
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
types.ts |
Adds new type aliases for better type safety and clarity |
toolbar.tsx |
Updates import to use the new AppearancePopover component |
titles_and_text_popover.tsx |
Removes the old popover implementation |
titles_and_text_popover.test.tsx |
Removes tests for the old popover |
title_weight_option.tsx |
Removes individual option component (consolidated) |
text_alignment_options.tsx |
Removes individual option components (consolidated) |
primary_position_option.tsx |
Removes individual option component (consolidated) |
appearance_popover.tsx |
Adds new unified appearance popover with improved organization |
appearance_popover.test.tsx |
Adds comprehensive tests for the new popover |
toolbar_popover.tsx |
Adjusts width and padding for better layout |
| Translation files | Removes outdated translation keys |
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_popover.tsx
Show resolved
Hide resolved
gvnmagni
approved these changes
Sep 10, 2025
|
Beautiful! |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
eleonoramicozzi
pushed a commit
to eleonoramicozzi/kibana
that referenced
this pull request
Sep 10, 2025
Closes elastic#233702 ## Summary Updates titles and text toolbar popover for metric chart, now called "Appearance". https://github.com/user-attachments/assets/54bcd8aa-cf87-45e2-a39c-3ec6fa8bf59e Shows all settings and disables the ones that weren't shown before: subtitle, secondary metric align and icon position. <img width="2560" height="906" alt="Screenshot 2025-09-04 at 13 41 46" src="https://github.com/user-attachments/assets/431e7e4a-6962-4de6-805e-8238ff6a72d4" /> #### Considerations Prevents unnecessary state updates by ensuring that when a user clicks an option that is already selected, the state is not updated. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
Closes elastic#233702 ## Summary Updates titles and text toolbar popover for metric chart, now called "Appearance". https://github.com/user-attachments/assets/54bcd8aa-cf87-45e2-a39c-3ec6fa8bf59e Shows all settings and disables the ones that weren't shown before: subtitle, secondary metric align and icon position. <img width="2560" height="906" alt="Screenshot 2025-09-04 at 13 41 46" src="https://github.com/user-attachments/assets/431e7e4a-6962-4de6-805e-8238ff6a72d4" /> #### Considerations Prevents unnecessary state updates by ensuring that when a user clicks an option that is already selected, the state is not updated. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
Closes elastic#233702 ## Summary Updates titles and text toolbar popover for metric chart, now called "Appearance". https://github.com/user-attachments/assets/54bcd8aa-cf87-45e2-a39c-3ec6fa8bf59e Shows all settings and disables the ones that weren't shown before: subtitle, secondary metric align and icon position. <img width="2560" height="906" alt="Screenshot 2025-09-04 at 13 41 46" src="https://github.com/user-attachments/assets/431e7e4a-6962-4de6-805e-8238ff6a72d4" /> #### Considerations Prevents unnecessary state updates by ensuring that when a user clicks an option that is already selected, the state is not updated. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
Closes #233702 ## Summary Updates titles and text toolbar popover for metric chart, now called "Appearance". https://github.com/user-attachments/assets/54bcd8aa-cf87-45e2-a39c-3ec6fa8bf59e Shows all settings and disables the ones that weren't shown before: subtitle, secondary metric align and icon position. <img width="2560" height="906" alt="Screenshot 2025-09-04 at 13 41 46" src="https://github.com/user-attachments/assets/431e7e4a-6962-4de6-805e-8238ff6a72d4" /> #### Considerations Prevents unnecessary state updates by ensuring that when a user clicks an option that is already selected, the state is not updated. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This was referenced Sep 30, 2025
alaudazzi
added a commit
to elastic/docs-content
that referenced
this pull request
Oct 3, 2025
This PR adds the new appearance settings for the metric chart. Closes #3088 Relates to elastic/kibana#229815 and elastic/kibana#233992
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233702
Summary
Updates titles and text toolbar popover for metric chart, now called "Appearance".
Screen.Recording.2025-09-04.at.13.44.56.mov
Shows all settings and disables the ones that weren't shown before: subtitle, secondary metric align and icon position.
Considerations
Prevents unnecessary state updates by ensuring that when a user clicks an option that is already selected, the state is not updated.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.