[ML] Anomaly Swim Lane: Fixes rendering of dashboard panel in PDF reporting#235475
Merged
rbrtj merged 5 commits intoelastic:mainfrom Sep 22, 2025
Merged
[ML] Anomaly Swim Lane: Fixes rendering of dashboard panel in PDF reporting#235475rbrtj merged 5 commits intoelastic:mainfrom
rbrtj merged 5 commits intoelastic:mainfrom
Conversation
rbrtj
added
release_note:fix
:ml
Team:ML
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Sep 18, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and confirmed the swim lane panel is rendered in PDF reports.
Don't want to block this PR, but for the SMV panel I noticed that the main chart sometimes doesn't get rendered, only the context chart.
Contributor
Author
As discussed, we decided to move forward with the fix for the Swimlane only for now. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @rbrtj |
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2025
…reporting (elastic#235475) Resolves elastic#234704 How to test: 1. create new dashboard and add a anomaly swimlane panel. 2. save dashboard 3. share dashboard as PDF 4. Open report and notice that panel is now displaying correctly | Before | After | | ------------- | ------------- | | <img width="1676" height="731" alt="image" src="https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21" /> | <img width="1687" height="615" alt="image" src="https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279" /> | (cherry picked from commit 7b68018)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2025
…reporting (elastic#235475) Resolves elastic#234704 How to test: 1. create new dashboard and add a anomaly swimlane panel. 2. save dashboard 3. share dashboard as PDF 4. Open report and notice that panel is now displaying correctly | Before | After | | ------------- | ------------- | | <img width="1676" height="731" alt="image" src="https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21" /> | <img width="1687" height="615" alt="image" src="https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279" /> | (cherry picked from commit 7b68018)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2025
…or PDF reporting (#235475) (#235962) # Backport This will backport the following commits from `main` to `8.19`: - [[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)](#235475) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-09-22T14:02:16Z","message":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)\n\nResolves https://github.com/elastic/kibana/issues/234704\n\nHow to test:\n1. create new dashboard and add a anomaly swimlane panel.\n2. save dashboard\n3. share dashboard as PDF\n4. Open report and notice that panel is now displaying correctly\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1676\" height=\"731\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21\"\n/> | <img width=\"1687\" height=\"615\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279\"\n/> |","sha":"7b6801816289d1f7a30d13335801de6f1c347451","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Team:ML","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting","number":235475,"url":"https://github.com/elastic/kibana/pull/235475","mergeCommit":{"message":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)\n\nResolves https://github.com/elastic/kibana/issues/234704\n\nHow to test:\n1. create new dashboard and add a anomaly swimlane panel.\n2. save dashboard\n3. share dashboard as PDF\n4. Open report and notice that panel is now displaying correctly\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1676\" height=\"731\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21\"\n/> | <img width=\"1687\" height=\"615\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279\"\n/> |","sha":"7b6801816289d1f7a30d13335801de6f1c347451"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/235475","number":235475,"mergeCommit":{"message":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)\n\nResolves https://github.com/elastic/kibana/issues/234704\n\nHow to test:\n1. create new dashboard and add a anomaly swimlane panel.\n2. save dashboard\n3. share dashboard as PDF\n4. Open report and notice that panel is now displaying correctly\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1676\" height=\"731\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21\"\n/> | <img width=\"1687\" height=\"615\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279\"\n/> |","sha":"7b6801816289d1f7a30d13335801de6f1c347451"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2025
…r PDF reporting (#235475) (#235963) # Backport This will backport the following commits from `main` to `9.1`: - [[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)](#235475) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-09-22T14:02:16Z","message":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)\n\nResolves https://github.com/elastic/kibana/issues/234704\n\nHow to test:\n1. create new dashboard and add a anomaly swimlane panel.\n2. save dashboard\n3. share dashboard as PDF\n4. Open report and notice that panel is now displaying correctly\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1676\" height=\"731\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21\"\n/> | <img width=\"1687\" height=\"615\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279\"\n/> |","sha":"7b6801816289d1f7a30d13335801de6f1c347451","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Team:ML","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting","number":235475,"url":"https://github.com/elastic/kibana/pull/235475","mergeCommit":{"message":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)\n\nResolves https://github.com/elastic/kibana/issues/234704\n\nHow to test:\n1. create new dashboard and add a anomaly swimlane panel.\n2. save dashboard\n3. share dashboard as PDF\n4. Open report and notice that panel is now displaying correctly\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1676\" height=\"731\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21\"\n/> | <img width=\"1687\" height=\"615\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279\"\n/> |","sha":"7b6801816289d1f7a30d13335801de6f1c347451"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/235475","number":235475,"mergeCommit":{"message":"[ML] Anomaly Swimlane Embeddable: Add `data-render-complete` for PDF reporting (#235475)\n\nResolves https://github.com/elastic/kibana/issues/234704\n\nHow to test:\n1. create new dashboard and add a anomaly swimlane panel.\n2. save dashboard\n3. share dashboard as PDF\n4. Open report and notice that panel is now displaying correctly\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1676\" height=\"731\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21\"\n/> | <img width=\"1687\" height=\"615\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279\"\n/> |","sha":"7b6801816289d1f7a30d13335801de6f1c347451"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
…reporting (elastic#235475) Resolves elastic#234704 How to test: 1. create new dashboard and add a anomaly swimlane panel. 2. save dashboard 3. share dashboard as PDF 4. Open report and notice that panel is now displaying correctly | Before | After | | ------------- | ------------- | | <img width="1676" height="731" alt="image" src="https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21" /> | <img width="1687" height="615" alt="image" src="https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279" /> |
peteharverson
changed the title
data-render-complete for PDF reporting
peteharverson
changed the title
data-render-complete for PDF reporting
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
…reporting (#235475) Resolves #234704 How to test: 1. create new dashboard and add a anomaly swimlane panel. 2. save dashboard 3. share dashboard as PDF 4. Open report and notice that panel is now displaying correctly | Before | After | | ------------- | ------------- | | <img width="1676" height="731" alt="image" src="https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21" /> | <img width="1687" height="615" alt="image" src="https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279" /> |
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…reporting (elastic#235475) Resolves elastic#234704 How to test: 1. create new dashboard and add a anomaly swimlane panel. 2. save dashboard 3. share dashboard as PDF 4. Open report and notice that panel is now displaying correctly | Before | After | | ------------- | ------------- | | <img width="1676" height="731" alt="image" src="https://github.com/user-attachments/assets/b752543f-7c73-452d-aab0-58d70f07dc21" /> | <img width="1687" height="615" alt="image" src="https://github.com/user-attachments/assets/a2a083d0-fd39-4155-9cad-1bbd95348279" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds data-render-complete for PDF reporting for the ML Anomaly Swim Lane dashboard panel.
Resolves #234704
How to test: