Skip to content

[ML] Anomaly Swim Lane: Fixes rendering of dashboard panel in PDF reporting #235475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbrtj merged 5 commits into from
Sep 22, 2025
Merged

[ML] Anomaly Swim Lane: Fixes rendering of dashboard panel in PDF reporting #235475

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5f01ff
add data-render-complete property
rbrtj Sep 18, 2025
8ea208e
Merge branch 'main' into anomaly-swimlane-embeddable-fix
rbrtj Sep 18, 2025
6165c68
Merge branch 'main' into anomaly-swimlane-embeddable-fix
rbrtj Sep 22, 2025
2dda802
Merge branch 'main' into anomaly-swimlane-embeddable-fix
rbrtj Sep 22, 2025
40f8367
Merge branch 'main' into anomaly-swimlane-embeddable-fix
rbrtj Sep 22, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 90 additions & 62 deletions ...ins/shared/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_embeddable_factory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
useBatchedPublishingSubjects,
} from '@kbn/presentation-publishing';
import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
import React, { useCallback, useState } from 'react';
import React, { useCallback, useEffect, useRef, useState } from 'react';
import useUnmount from 'react-use/lib/useUnmount';
import type { Observable } from 'rxjs';
import {
Expand All @@ -43,6 +43,7 @@ import {
} from 'rxjs';
import fastIsEqual from 'fast-deep-equal';
import { initializeUnsavedChanges } from '@kbn/presentation-containers';
import { dispatchRenderComplete, dispatchRenderStart } from '@kbn/kibana-utils-plugin/public';
import type { AnomalySwimlaneEmbeddableServices } from '..';
import { ANOMALY_SWIMLANE_EMBEDDABLE_TYPE } from '..';
import type { MlDependencies } from '../../application/app';
Expand Down Expand Up @@ -271,8 +272,6 @@ export const getAnomalySwimLaneEmbeddableFactory = (
})
);

const onRenderComplete = () => {};

return {
api,
Component: () => {
Expand All @@ -298,17 +297,42 @@ export const getAnomalySwimLaneEmbeddableFactory = (
subscriptions.unsubscribe();
});

const [fromPage, perPage, swimlaneType, swimlaneData, error] =
const [fromPage, perPage, swimlaneType, swimlaneData, error, isLoading] =
useBatchedPublishingSubjects(
api.fromPage,
api.perPage,
api.swimlaneType,
swimLaneData$,
blockingError$
blockingError$,
dataLoading$
);

const [selectedCells, setSelectedCells] = useState<AppStateSelectedCells | undefined>();

const [hasRendered, setHasRendered] = useState<boolean>(false);
const wrapperRef = useRef<HTMLDivElement>(null);
useEffect(() => {
if (isLoading) setHasRendered(false);
}, [isLoading]);

useEffect(
function dispatchRenderMessages() {
const el = wrapperRef.current;
if (!el) return;
if (error) {
dispatchRenderComplete(el);
return;
}
if (isLoading) {
dispatchRenderStart(el);
return;
}
if (hasRendered) {
dispatchRenderComplete(el);
}
},
[isLoading, hasRendered, error]
);

const onCellsSelection = useCallback(
(update?: AppStateSelectedCells) => {
setSelectedCells(update);
Expand All @@ -325,24 +349,6 @@ export const getAnomalySwimLaneEmbeddableFactory = (
[swimlaneData, perPage, setSelectedCells]
);

if (error) {
return (
<EuiCallOut
title={
<FormattedMessage
id="xpack.ml.swimlaneEmbeddable.errorMessage"
defaultMessage="Unable to load the data for the swim lane"
/>
}
color="danger"
iconType="warning"
css={{ width: '100%' }}
>
<p>{error.message}</p>
</EuiCallOut>
);
}

return (
<KibanaRenderContextProvider {...coreStartServices}>
<KibanaContextProvider services={{ ...coreStartServices }}>
Expand All @@ -353,48 +359,70 @@ export const getAnomalySwimLaneEmbeddableFactory = (
`}
data-test-subj="mlAnomalySwimlaneEmbeddableWrapper"
data-shared-item="" // TODO: Remove data-shared-item as part of https://github.com/elastic/kibana/issues/179376
data-render-complete={error ? true : hasRendered}
ref={wrapperRef}
>
<SwimlaneContainer
id={uuid}
data-test-subj={`mlSwimLaneEmbeddable_${uuid}`}
timeBuckets={timeBuckets}
swimlaneData={swimlaneData!}
swimlaneType={swimlaneType}
fromPage={fromPage}
perPage={perPage}
swimlaneLimit={
isViewBySwimLaneData(swimlaneData) ? swimlaneData.cardinality : undefined
}
onResize={(size) => chartWidth$.next(size)}
selection={selectedCells}
onCellsSelection={onCellsSelection}
onPaginationChange={(update) => {
if (update.fromPage) {
api.updatePagination({ fromPage: update.fromPage });
{error ? (
<EuiCallOut
title={
<FormattedMessage
id="xpack.ml.swimlaneEmbeddable.errorMessage"
defaultMessage="Unable to load the data for the swim lane"
/>
}
if (update.perPage) {
api.updatePagination({ perPage: update.perPage, fromPage: 1 });
color="danger"
iconType="warning"
css={{ width: '100%' }}
>
<p>{error.message}</p>
</EuiCallOut>
) : (
<SwimlaneContainer
id={uuid}
data-test-subj={`mlSwimLaneEmbeddable_${uuid}`}
timeBuckets={timeBuckets}
swimlaneData={swimlaneData!}
swimlaneType={swimlaneType}
fromPage={fromPage}
perPage={perPage}
swimlaneLimit={
isViewBySwimLaneData(swimlaneData) ? swimlaneData.cardinality : undefined
}
onResize={(size) => chartWidth$.next(size)}
selection={selectedCells}
onCellsSelection={onCellsSelection}
onPaginationChange={(update) => {
if (update.fromPage) {
api.updatePagination({ fromPage: update.fromPage });
}
if (update.perPage) {
api.updatePagination({ perPage: update.perPage, fromPage: 1 });
}
}}
isLoading={isLoading!}
yAxisWidth={{ max: Y_AXIS_LABEL_WIDTH }}
noDataWarning={
<EuiEmptyPrompt
titleSize="xxs"
css={{ padding: 0 }}
title={
<h2>
<FormattedMessage
id="xpack.ml.swimlaneEmbeddable.noDataFound"
defaultMessage="No anomalies found"
/>
</h2>
}
/>
}
}}
isLoading={dataLoading$.value!}
yAxisWidth={{ max: Y_AXIS_LABEL_WIDTH }}
noDataWarning={
<EuiEmptyPrompt
titleSize="xxs"
css={{ padding: 0 }}
title={
<h2>
<FormattedMessage
id="xpack.ml.swimlaneEmbeddable.noDataFound"
defaultMessage="No anomalies found"
/>
</h2>
chartsService={pluginsStartServices.charts}
onRenderComplete={() => {
if (!isLoading) {
setHasRendered(true);
}
/>
}
chartsService={pluginsStartServices.charts}
onRenderComplete={onRenderComplete}
/>
}}
/>
)}
</div>
</KibanaContextProvider>
</KibanaRenderContextProvider>
Expand Down