[Dashboard] Top Nav Save Menu by cqliu1 · Pull Request #237211 · elastic/kibana

cqliu1 · 2025-10-01T23:45:50Z

Summary

Closes #192630.
Closes #237210.

This moves the Save as and Reset top nav actions into a split button menu next to the Save button in edit mode.

With unsaved changes

View mode

The duplicate and reset actions remain in the top nav in view mode.

Editing a new dashboard

The save button returns to a normal button with no additional save options.

I also cleaned up styles for the add menu

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

elasticmachine · 2025-10-01T23:47:19Z

Pinging @elastic/kibana-presentation (Team:Presentation)

kowalczyk-krzysztof · 2025-10-02T08:03:58Z

@cqliu1
Do you think this will have an impact on write-restricted dashboards? Could you please check that PR and see if your PR won't break any functionality needed in there?

cqliu1 · 2025-10-07T16:00:19Z

@cqliu1
Do you think this will have an impact on write-restricted dashboards? Could you please check that PR and see if your PR won't break any functionality needed in there?

@kowalczyk-krzysztof It shouldn't break your write-restricted dashboards functionality, but I am moving the Save as button into a menu. We'll just need to be careful when resolving merge conflicts.

kowalczyk-krzysztof · 2025-10-07T17:16:16Z

@cqliu1
Do you think this will have an impact on write-restricted dashboards? Could you please check that PR and see if your PR won't break any functionality needed in there?

@kowalczyk-krzysztof It shouldn't break your write-restricted dashboards functionality, but I am moving the Save as button into a menu. We'll just need to be careful when resolving merge conflicts.

Thanks for looking into this @cqliu1!

@SiddharthMantri @jeramysoucy This PR will most likely get merged first but not before I go on PTO. Please make sure to reach out to @cqliu1 if you run into any issues with resolving conflicts.

davismcphee

Code-only review, Data Discovery changes LGTM 👍 Just minor changes to the split button package.

…rd/top-nav-save-menu

kowalczyk-krzysztof

SharedUX code changes LGTM 🚀
I also tried integrating this into my write-restricted dashboards PR and it went surprisingly smoothly.

andreadelrio

@cqliu1 Design changes LGTM! Nicely done!

nreese

kibana-presentation changes LGTM
code review and tested in chrome

cqliu1 · 2025-11-03T15:46:12Z

@elasticmachine merge upstream

elasticmachine · 2025-11-03T23:31:57Z

⏳ Build in-progress

History

💚 Build #357772 succeeded 3387b12
💛 Build #357330 was flaky b5c052d
💛 Build #357291 was flaky 4620bd1
💔 Build #357281 failed ea14dde
💚 Build #356825 succeeded a12553b
💚 Build #356521 succeeded 4002dcc

## Summary Closes elastic#192630. Closes [elastic#237210](elastic#237210). This moves the `Save as` and `Reset` top nav actions into a split button menu next to the `Save` button in edit mode. <img width="1188" height="777" alt="Screenshot 2025-10-29 at 10 18 39 AM" src="https://github.com/user-attachments/assets/06ac1310-e3f7-4251-ade0-3b94eeb5d8d2" /> #### With unsaved changes <img width="624" height="164" alt="Screenshot 2025-10-29 at 10 20 33 AM" src="https://github.com/user-attachments/assets/4e42212f-b7f1-4b29-9525-6b2b6ee6f207" /> #### View mode The duplicate and reset actions remain in the top nav in view mode. <img width="428" height="168" alt="Screenshot 2025-10-29 at 10 21 29 AM" src="https://github.com/user-attachments/assets/3d70796f-c2f6-4312-b017-3dc5f0461388" /> #### Editing a new dashboard The save button returns to a normal button with no additional save options. <img width="456" height="124" alt="Screenshot 2025-10-29 at 10 22 13 AM" src="https://github.com/user-attachments/assets/7c0ca3e6-e567-43d2-9a4e-6c25fd9e03f2" /> I also cleaned up styles for the add menu <img width="440" height="526" alt="Screenshot 2025-10-29 at 10 12 57 AM" src="https://github.com/user-attachments/assets/e8117793-14da-472a-9aaf-ebc3d55e94f0" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

cqliu1 requested review from a team as code owners October 1, 2025 23:45

cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// labels Oct 1, 2025

cqliu1 marked this pull request as draft October 7, 2025 16:40

cqliu1 added release_note:enhancement backport:skip This PR does not require backporting loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v9.3.0 labels Oct 8, 2025

cqliu1 force-pushed the dashboard/top-nav-save-menu branch from 173730d to b0cbc86 Compare October 13, 2025 16:33

cqliu1 added 3 commits October 28, 2025 16:32

Add save more menu

67a3c3d

Add split button to top nav

763cb44

Fix split button

3372080

cqliu1 force-pushed the dashboard/top-nav-save-menu branch from f3f2b7c to 3372080 Compare October 29, 2025 16:45

cqliu1 added the ci:cloud-deploy Create or update a Cloud deployment label Oct 29, 2025

cqliu1 added 3 commits October 29, 2025 09:52

Remove console logs

d27eca5

Fix save as

3ac7db0

Attach add menu popover and fix width

189659b

cqliu1 force-pushed the dashboard/top-nav-save-menu branch from ddfeb82 to 189659b Compare October 29, 2025 17:26

cqliu1 added 6 commits October 29, 2025 10:30

Clean up strings

516ed61

Remove unsaved badges changes

157986b

Clean up reset changes

67bc1ac

More cleanup

1336d46

More clean up

1077126

More cleanup

3a50628

cqliu1 added 5 commits October 29, 2025 12:56

clean up

f0be1be

Fix button fill

8ac2880

Revert change

df1e07f

Update bundle limit for navigation plugin

79315e9

Add awaits

3e33ba9

cqliu1 marked this pull request as ready for review October 29, 2025 20:07

cqliu1 requested review from a team as code owners October 29, 2025 20:07

jbudz approved these changes Oct 29, 2025

View reviewed changes

Fix clickDiscardChanges

a2c449f

davismcphee approved these changes Oct 30, 2025

View reviewed changes

cqliu1 added 2 commits October 29, 2025 21:14

Fix save as

4002dcc

Merge branch 'main' of https://github.com/elastic/kibana into dashboa…

a12553b

…rd/top-nav-save-menu

kowalczyk-krzysztof approved these changes Oct 30, 2025

View reviewed changes

cqliu1 requested a review from andreadelrio October 30, 2025 16:43

andreadelrio approved these changes Oct 30, 2025

View reviewed changes

cqliu1 and others added 3 commits October 31, 2025 09:17

fix dark mode

ea14dde

Changes from node scripts/eslint_all_files --no-cache --fix

4620bd1

Merge branch 'main' into dashboard/top-nav-save-menu

b5c052d

nreese approved these changes Nov 1, 2025

View reviewed changes

Merge branch 'main' into dashboard/top-nav-save-menu

3387b12

cqliu1 enabled auto-merge (squash) November 3, 2025 17:24

Merge branch 'main' into dashboard/top-nav-save-menu

19e4b6d

cqliu1 merged commit 247d386 into elastic:main Nov 4, 2025
12 checks passed

florent-leborgne added the needs_docs label Nov 19, 2025

florent-leborgne mentioned this pull request Dec 10, 2025

[Dashboards] "Save as" and "Reset" top nav actions moved into a split button menu next to the Save button in edit mode elastic/docs-content#4266

Closed

cqliu1 mentioned this pull request Dec 22, 2025

[Dashboard] Invalid prop run on <button> tag in top nav split button #247304

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Top Nav Save Menu#237211

[Dashboard] Top Nav Save Menu#237211
cqliu1 merged 32 commits intoelastic:mainfrom
cqliu1:dashboard/top-nav-save-menu

cqliu1 commented Oct 1, 2025 •

edited

Loading

elasticmachine commented Oct 1, 2025

kowalczyk-krzysztof commented Oct 2, 2025

cqliu1 commented Oct 7, 2025 •

edited

Loading

kowalczyk-krzysztof commented Oct 7, 2025

davismcphee left a comment

kowalczyk-krzysztof left a comment

andreadelrio left a comment

nreese left a comment

cqliu1 commented Nov 3, 2025

elasticmachine commented Nov 3, 2025

Uh oh!

Labels

9 participants

Conversation

cqliu1 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

With unsaved changes

View mode

Editing a new dashboard

Checklist

Identify risks

elasticmachine commented Oct 1, 2025

kowalczyk-krzysztof commented Oct 2, 2025

cqliu1 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

kowalczyk-krzysztof commented Oct 7, 2025

davismcphee left a comment

Choose a reason for hiding this comment

kowalczyk-krzysztof left a comment

Choose a reason for hiding this comment

andreadelrio left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

cqliu1 commented Nov 3, 2025

elasticmachine commented Nov 3, 2025

⏳ Build in-progress

History

Uh oh!

Labels

9 participants

cqliu1 commented Oct 1, 2025 •

edited

Loading

cqliu1 commented Oct 7, 2025 •

edited

Loading