[Search][Accessibility] Show error text when fields are invalid#238284
Merged
seialkali merged 1 commit intoelastic:mainfrom Oct 10, 2025
Merged
[Search][Accessibility] Show error text when fields are invalid#238284seialkali merged 1 commit intoelastic:mainfrom
seialkali merged 1 commit intoelastic:mainfrom
Conversation
seialkali
added
release_note:fix
Team:Search
backport:version
seialkali
force-pushed
the
fix/rag-playground-error-text-missing
branch
from
0b8c733 to
f8f07ff
Compare
wildemat
requested changes
Oct 9, 2025
...ns/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
Outdated
Show resolved
Hide resolved
...ns/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
Outdated
Show resolved
Hide resolved
seialkali
force-pushed
the
fix/rag-playground-error-text-missing
branch
from
f8f07ff to
a48cbdf
Compare
wildemat
approved these changes
Oct 10, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues. (cherry picked from commit 3a56deb)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
seialkali
added a commit
to seialkali/kibana
that referenced
this pull request
Oct 10, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues. (cherry picked from commit 3a56deb) # Conflicts: # x-pack/solutions/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
seialkali
added a commit
to seialkali/kibana
that referenced
this pull request
Oct 10, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues. (cherry picked from commit 3a56deb) # Conflicts: # x-pack/solutions/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
This was referenced Oct 10, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
seialkali
added a commit
to seialkali/kibana
that referenced
this pull request
Oct 10, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues. (cherry picked from commit 3a56deb) # Conflicts: # x-pack/solutions/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
seialkali
added a commit
to seialkali/kibana
that referenced
this pull request
Oct 10, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues. (cherry picked from commit 3a56deb) # Conflicts: # x-pack/solutions/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2025
…#238284) (#238465) # Backport This will backport the following commits from `main` to `9.2`: - [[Search][Accessibility] Show error text when fields are invalid (#238284)](#238284) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2025-10-10T14:12:08Z","message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Search","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.18.9","v8.19.6","v9.0.9"],"title":"[Search][Accessibility] Show error text when fields are invalid","number":238284,"url":"https://github.com/elastic/kibana/pull/238284","mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.18","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238284","number":238284,"mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Brittany <seialkali@gmail.com>
seialkali
added a commit
that referenced
this pull request
Oct 13, 2025
#238284) (#238506) # Backport This will backport the following commits from `main` to `8.19`: - [[Search][Accessibility] Show error text when fields are invalid (#238284)](#238284) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2025-10-10T14:12:08Z","message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Search","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.18.9","v8.19.6","v9.0.9"],"title":"[Search][Accessibility] Show error text when fields are invalid","number":238284,"url":"https://github.com/elastic/kibana/pull/238284","mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.18","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238465","number":238465,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238284","number":238284,"mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
yansavitski
pushed a commit
that referenced
this pull request
Oct 13, 2025
seialkali
added a commit
that referenced
this pull request
Oct 13, 2025
#238284) (#238507) # Backport This will backport the following commits from `main` to `8.18`: - [[Search][Accessibility] Show error text when fields are invalid (#238284)](#238284) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2025-10-10T14:12:08Z","message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Search","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.18.9","v8.19.6","v9.0.9"],"title":"[Search][Accessibility] Show error text when fields are invalid","number":238284,"url":"https://github.com/elastic/kibana/pull/238284","mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.18","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238465","number":238465,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238284","number":238284,"mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
seialkali
added a commit
that referenced
this pull request
Oct 13, 2025
…#238284) (#238505) # Backport This will backport the following commits from `main` to `9.0`: - [[Search][Accessibility] Show error text when fields are invalid (#238284)](#238284) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2025-10-10T14:12:08Z","message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Search","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.18.9","v8.19.6","v9.0.9"],"title":"[Search][Accessibility] Show error text when fields are invalid","number":238284,"url":"https://github.com/elastic/kibana/pull/238284","mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.18","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238465","number":238465,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238284","number":238284,"mergeCommit":{"message":"[Search][Accessibility] Show error text when fields are invalid (#238284)\n\n## Summary\n\nThis PR ensures that when a field in the RAG Playground is in an error\nstate, the corresponding error text is displayed below the field.\nPreviously, only the red error styling was applied without any\naccompanying message, which did not meet accessibility requirements.\n\n<img width=\"600\" height=\"686\" alt=\"Screenshot 2025-10-09 at 16 10 06\"\nsrc=\"https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61\"\n/>\n\n### Testing\n\n1. Navigate to Search → Build → RAG Playground.\n2. In the Instructions field, delete all text and press Tab.\n3. Confirm that an error message appears below the field (e.g.,\n“Instructions cannot be empty”).\n4. In the Context fields input, enter any text (e.g., test), then press\nTab.\n5. Confirm that invalid entries display a red border and an error\nmessage below the field.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes an issue in the RAG Playground where invalid fields displayed red\nstyling but no error message. Error text is now shown to help users\nidentify and correct form issues.","sha":"3a56deb3f6b5187c60f9a38ac416c9322f76bd31"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…tic#238284) ## Summary This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements. <img width="600" height="686" alt="Screenshot 2025-10-09 at 16 10 06" src="https://github.com/user-attachments/assets/ef980bcb-cae0-4c5c-a330-c4e20bbbfd61" /> ### Testing 1. Navigate to Search → Build → RAG Playground. 2. In the Instructions field, delete all text and press Tab. 3. Confirm that an error message appears below the field (e.g., “Instructions cannot be empty”). 4. In the Context fields input, enter any text (e.g., test), then press Tab. 5. Confirm that invalid entries display a red border and an error message below the field. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that when a field in the RAG Playground is in an error state, the corresponding error text is displayed below the field. Previously, only the red error styling was applied without any accompanying message, which did not meet accessibility requirements.
Testing
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.Flaky Test Runner was used on any tests changedrelease_note:*label is applied per the guidelinesbackport:*labels.Release note
Fixes an issue in the RAG Playground where invalid fields displayed red styling but no error message. Error text is now shown to help users identify and correct form issues.