Skip to content

[Search][Accessibility] Show error text when fields are invalid #238284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seialkali merged 1 commit into from
Oct 10, 2025
Merged

[Search][Accessibility] Show error text when fields are invalid #238284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 48 additions & 9 deletions ...search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
* 2.0.
*/

import React, { useMemo, useCallback } from 'react';
import React, { useMemo, useCallback, useState, useRef } from 'react';

import type { EuiComboBoxOptionOption } from '@elastic/eui';
import { EuiCallOut, EuiComboBox } from '@elastic/eui';
import { EuiCallOut, EuiComboBox, EuiFormRow } from '@elastic/eui';
import { i18n } from '@kbn/i18n';

import type { QuerySourceFields } from '../../types';
Expand All @@ -26,6 +26,24 @@ export const ContextFieldsSelect = ({
selectedContextFields,
updateSelectedContextFields,
}: ContextFieldsSelectProps) => {
const searchValue = useRef('');
const [hasError, setHasError] = useState(false);

const handleSearchChange = (value: string) => {
searchValue.current = value;
setHasError(false);
};

const handleBlur = () => {
if (searchValue.current.trim() === '') return;

const hasExactMatch = selectOptions.some(
(opt) => opt.label.toLowerCase() === searchValue.current.toLowerCase()
);

setHasError(!hasExactMatch);
};

const { options: selectOptions, selectedOptions } = useMemo(() => {
if (!indexFields.source_fields?.length) return { options: [], selectedOptions: [] };

Expand Down Expand Up @@ -75,13 +93,34 @@ export const ContextFieldsSelect = ({
}

return (
<EuiComboBox
data-test-subj={`contextFieldsSelectable-${indexName}`}
options={selectOptions}
selectedOptions={selectedOptions}
onChange={onSelectFields}
isClearable={false}
<EuiFormRow
fullWidth
/>
isInvalid={hasError}
error={
hasError
? `"${searchValue.current}" ${i18n.translate(
'xpack.searchPlayground.editContext.noSourceFieldWarning',
{
defaultMessage: 'does not match any options',
}
)}`
: undefined
}
>
<EuiComboBox
data-test-subj={`contextFieldsSelectable-${indexName}`}
options={selectOptions}
selectedOptions={selectedOptions}
onChange={onSelectFields}
isClearable={false}
fullWidth
aria-label={i18n.translate('xpack.searchPlayground.editContext.', {
defaultMessage: 'Select context field options',
})}
onSearchChange={handleSearchChange}
onBlur={handleBlur}
isInvalid={hasError}
/>
</EuiFormRow>
);
};
8 changes: 8 additions & 0 deletions ...ch/plugins/search_playground/public/components/summarization_panel/instructions_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ export const InstructionsField: React.FC<InstructionsFieldProps> = ({ value, onC
</span>
}
fullWidth
isInvalid={isEmpty(value)}
error={
isEmpty(value)
? i18n.translate('xpack.searchPlayground.sidebar.instructionsField.errorMessage', {
defaultMessage: 'Instructions cannot be empty',
})
: undefined
}
>
<EuiTextArea
data-test-subj="instructionsPrompt"
Expand Down