[Cases] A11y - Fix missing announcements in form row#240132
Merged
christineweng merged 2 commits intoelastic:mainfrom Oct 23, 2025
Merged
[Cases] A11y - Fix missing announcements in form row#240132christineweng merged 2 commits intoelastic:mainfrom
christineweng merged 2 commits intoelastic:mainfrom
Conversation
christineweng
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cases (Team:Cases) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
TIL! |
janmonschke
reviewed
Oct 23, 2025
| return ( | ||
| <EuiSuperSelect | ||
| aria-label={i18n.INCIDENT_MANAGEMENT_SYSTEM_LABEL} | ||
| aria-label={i18n.CONNECTOR_DROPDOWN_LABEL} |
janmonschke
approved these changes
Oct 23, 2025
christineweng
added
release_note:fix
and removed
release_note:skip
Contributor
|
Starting backport for target branches: 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2025
## Summary Fixes: - elastic#230004 - elastic#205616 - elastic#205706 Why they were broken before: `EuiFormRow` sets the necessary ARIA attributes directly on its first child. Any wrappers break this mechanism. This PR fixes the issue by passing `{...props}` to the eui control componenets. <img width="696" height="247" alt="image" src="https://github.com/user-attachments/assets/ba3e7732-a7fe-4bd0-b984-61931a848120" /> <img width="592" height="455" alt="image" src="https://github.com/user-attachments/assets/e26dd19b-4b87-463e-a965-2775a535af10" /> <img width="767" height="376" alt="image" src="https://github.com/user-attachments/assets/feade26b-d907-4757-b449-50367b50ab2d" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2d029f4)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2025
…240303) # Backport This will backport the following commits from `main` to `9.2`: - [[Cases] A11y - Fix missing announcements in form row (#240132)](#240132) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-23T14:03:54Z","message":"[Cases] A11y - Fix missing announcements in form row (#240132)\n\n## Summary\n\nFixes:\n- https://github.com/elastic/kibana/issues/230004\n- https://github.com/elastic/kibana/issues/205616\n- https://github.com/elastic/kibana/issues/205706\n\nWhy they were broken before: `EuiFormRow` sets the necessary ARIA\nattributes directly on its first child. Any wrappers break this\nmechanism. This PR fixes the issue by passing `{...props}` to the eui\ncontrol componenets.\n\n<img width=\"696\" height=\"247\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ba3e7732-a7fe-4bd0-b984-61931a848120\"\n/>\n\n<img width=\"592\" height=\"455\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e26dd19b-4b87-463e-a965-2775a535af10\"\n/>\n\n\n\n<img width=\"767\" height=\"376\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/feade26b-d907-4757-b449-50367b50ab2d\"\n/>\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2d029f4d8cd1f8e7673509aaef08371cbc28ca3c","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","Team:Cases","v9.2.0","v9.3.0"],"title":"[Cases] A11y - Fix missing announcements in form row","number":240132,"url":"https://github.com/elastic/kibana/pull/240132","mergeCommit":{"message":"[Cases] A11y - Fix missing announcements in form row (#240132)\n\n## Summary\n\nFixes:\n- https://github.com/elastic/kibana/issues/230004\n- https://github.com/elastic/kibana/issues/205616\n- https://github.com/elastic/kibana/issues/205706\n\nWhy they were broken before: `EuiFormRow` sets the necessary ARIA\nattributes directly on its first child. Any wrappers break this\nmechanism. This PR fixes the issue by passing `{...props}` to the eui\ncontrol componenets.\n\n<img width=\"696\" height=\"247\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ba3e7732-a7fe-4bd0-b984-61931a848120\"\n/>\n\n<img width=\"592\" height=\"455\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e26dd19b-4b87-463e-a965-2775a535af10\"\n/>\n\n\n\n<img width=\"767\" height=\"376\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/feade26b-d907-4757-b449-50367b50ab2d\"\n/>\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2d029f4d8cd1f8e7673509aaef08371cbc28ca3c"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240132","number":240132,"mergeCommit":{"message":"[Cases] A11y - Fix missing announcements in form row (#240132)\n\n## Summary\n\nFixes:\n- https://github.com/elastic/kibana/issues/230004\n- https://github.com/elastic/kibana/issues/205616\n- https://github.com/elastic/kibana/issues/205706\n\nWhy they were broken before: `EuiFormRow` sets the necessary ARIA\nattributes directly on its first child. Any wrappers break this\nmechanism. This PR fixes the issue by passing `{...props}` to the eui\ncontrol componenets.\n\n<img width=\"696\" height=\"247\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/ba3e7732-a7fe-4bd0-b984-61931a848120\"\n/>\n\n<img width=\"592\" height=\"455\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e26dd19b-4b87-463e-a965-2775a535af10\"\n/>\n\n\n\n<img width=\"767\" height=\"376\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/feade26b-d907-4757-b449-50367b50ab2d\"\n/>\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2d029f4d8cd1f8e7673509aaef08371cbc28ca3c"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
This was referenced Oct 24, 2025
Closed
jmikell821
added
the
Team:ResponseOps
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes:
Why they were broken before:
EuiFormRowsets the necessary ARIA attributes directly on its first child. Any wrappers break this mechanism. This PR fixes the issue by passing{...props}to the eui control componenets.Checklist
release_note:*label is applied per the guidelinesbackport:*labels.