[Fleet] fix icon loading with default icon#242406
Merged
teresaromero merged 2 commits intoelastic:mainfrom Nov 11, 2025
Merged
Conversation
…yForRq and handle fallback for default package icon
teresaromero
added
release_note:fix
backport:skip
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
|
nchaulet
approved these changes
Nov 10, 2025
Member
nchaulet
left a comment
nchaulet
left a comment
There was a problem hiding this comment.
Tested locally and works as expected 🚀
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
## Summary Fix elastic#111088 When loading the fleet data streams table, some icons are not loaded correctly and appear with the default 'package' icon. Updated the deprecated `sendGetPackageInfoByKey` function and use `sendGetPackageInfoByKeyForRq` instead. This alone did not solve the problem. When fetching for the icon list of a given package, only set the default 'package' icon type if the item list is undefined. Attached capture of the new behavior. https://github.com/user-attachments/assets/aeb28ae6-cb46-42d5-a6a9-a82f9edee168 ### Testing Running locally kibana with fleet and an agent enrolled via docker. Installed different integrations, specially system and system audit, this last one uses the default package icon. I found one of my solutions to not show the default icon so kept this one to check they worked ok too. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... ## Release note Fix package icons loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #111088
When loading the fleet data streams table, some icons are not loaded correctly and appear with the default 'package' icon.
Updated the deprecated
sendGetPackageInfoByKeyfunction and usesendGetPackageInfoByKeyForRqinstead. This alone did not solve the problem.When fetching for the icon list of a given package, only set the default 'package' icon type if the item list is undefined.
Attached capture of the new behavior.
Screen.Recording.2025-11-10.at.13.57.26.mov
Testing
Running locally kibana with fleet and an agent enrolled via docker.
Installed different integrations, specially system and system audit, this last one uses the default package icon. I found one of my solutions to not show the default icon so kept this one to check they worked ok too.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
Release note
Fix package icons loading