Skip to content

[Fleet] fix icon loading with default icon #242406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teresaromero merged 2 commits into from
Nov 11, 2025
Merged

[Fleet] fix icon loading with default icon #242406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612ea85
Refactor API call in usePackageIconType to use sendGetPackageInfoByKe…
teresaromero Nov 10, 2025
b7ec8f7
Merge branch 'main' of github.com:elastic/kibana into 111088-fix-icons
teresaromero Nov 10, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions x-pack/platform/plugins/shared/fleet/public/hooks/use_package_icon_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type { PackageInfo, PackageListItem } from '../types';
// Import the specific hook to avoid a circular dependency in Babel
import { useLinks as useEPMLinks } from '../applications/integrations/hooks/use_links';

import { sendGetPackageInfoByKey } from '.';
import { sendGetPackageInfoByKeyForRq } from '.';

type Package = PackageInfo | PackageListItem;

Expand Down Expand Up @@ -66,16 +66,19 @@ export const usePackageIconType = ({
}

if (tryApi && !paramIcons && !iconList) {
sendGetPackageInfoByKey(packageName, version)
sendGetPackageInfoByKeyForRq(packageName, version)
.catch((error) => undefined) // Ignore API errors
.then((res) => {
CACHED_ICONS.delete(cacheKey);
setIconList(res?.data?.item?.icons);
setIconList(res?.item?.icons);

// fallback to default package icon if no icons found from API
if (!res?.item?.icons) {
CACHED_ICONS.set(cacheKey, 'package');
setIconType('package');
}
});
}

CACHED_ICONS.set(cacheKey, 'package');
setIconType('package');
}, [paramIcons, cacheKey, toPackageImage, iconList, packageName, iconType, tryApi, version]);

if (iconType !== '') {
Expand Down
Loading