[dashboard] fix 'sync colors' and 'sync tooltips' must be ON by default#242442
Merged
nreese merged 5 commits intoelastic:mainfrom Nov 11, 2025
Merged
[dashboard] fix 'sync colors' and 'sync tooltips' must be ON by default#242442nreese merged 5 commits intoelastic:mainfrom
nreese merged 5 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
Contributor
Author
|
/ci |
nreese
added
release_note:fix
Team:Presentation
nickpeihl
approved these changes
Nov 11, 2025
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! thanks for the fix
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…lt (elastic#242442) Closes elastic#242373 Regression caused by elastic#238129. PR removed options from `DEFAULT_DASHBOARD_STATE` and starting using existing [DEFAULT_DASHBOARD_OPTIONS](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/dashboard/common/content_management/constants.ts#L19). `DEFAULT_DASHBOARD_OPTIONS` added in elastic#193067. The problem is that `DEFAULT_DASHBOARD_OPTIONS` does not have the same values as options in `DEFAULT_DASHBOARD_STATE` and this was missed during review. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242373
Regression caused by #238129. PR removed options from
DEFAULT_DASHBOARD_STATEand starting using existing DEFAULT_DASHBOARD_OPTIONS.DEFAULT_DASHBOARD_OPTIONSadded in #193067. The problem is thatDEFAULT_DASHBOARD_OPTIONSdoes not have the same values as options inDEFAULT_DASHBOARD_STATEand this was missed during review.