Fix "now" and mixed format date handling in share modal#245539
Merged
kowalczyk-krzysztof merged 7 commits intoelastic:mainfrom Dec 10, 2025
Merged
Conversation
kowalczyk-krzysztof
added
the
bug
kowalczyk-krzysztof
added
release_note:fix
backport:all-open
kowalczyk-krzysztof
added
papercut
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
nreese
approved these changes
Dec 9, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM. Thanks for fixing this issue
code review only
akowalska622
approved these changes
Dec 9, 2025
Contributor
akowalska622
left a comment
akowalska622
left a comment
There was a problem hiding this comment.
Data Discovery code only review LGTM
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
eokoneyo
approved these changes
Dec 10, 2025
Contributor
eokoneyo
left a comment
eokoneyo
left a comment
There was a problem hiding this comment.
changes LGTM, left a comment
Comment on lines
+128
to
+136
| const handleTimeTypeChange = useCallback( | ||
| (isAbsolute: boolean) => { | ||
| if (urlToCopy?.current && isAbsolute !== isAbsoluteTime) { | ||
| urlToCopy.current = undefined; | ||
| } | ||
| setIsAbsoluteTime(isAbsolute); | ||
| }, | ||
| [isAbsoluteTime] | ||
| ); |
Contributor
There was a problem hiding this comment.
nit: we could improve this further, such that we simply pass the setIsAbsolute method to onTimeTypeChange and then react to changes to it's value to set urlToCopy only within the context it was defined, your call.
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kowalczyk-krzysztof
added a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Dec 10, 2025
## Summary This PR fixes a bug where mixed dates (e.g one absolute and one relative) wouldn't work properly and "now" was rendering as 0 seconds in share modal date switcher. <img width="494" height="432" alt="Screenshot 2025-12-09 at 13 13 05" src="https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a" /> It also makes `ShareableUrlLocatorParams` strongly typed, requiring `timeRange` to be always present even if it has an undefined value, in response to a regression where dashboard time range parameter name was renamed to be snake_case, which broke the functionality as `TimeTypeSection` would always expect `timeRange`. Closes: elastic#241084 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bae752e) # Conflicts: # src/platform/plugins/shared/discover/public/application/main/components/top_nav/app_menu_actions/get_share.tsx # src/platform/plugins/shared/share/moon.yml
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kowalczyk-krzysztof
added a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Dec 10, 2025
## Summary This PR fixes a bug where mixed dates (e.g one absolute and one relative) wouldn't work properly and "now" was rendering as 0 seconds in share modal date switcher. <img width="494" height="432" alt="Screenshot 2025-12-09 at 13 13 05" src="https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a" /> It also makes `ShareableUrlLocatorParams` strongly typed, requiring `timeRange` to be always present even if it has an undefined value, in response to a regression where dashboard time range parameter name was renamed to be snake_case, which broke the functionality as `TimeTypeSection` would always expect `timeRange`. Closes: elastic#241084 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bae752e) # Conflicts: # src/platform/plugins/shared/discover/public/application/main/components/top_nav/app_menu_actions/get_share.tsx # src/platform/plugins/shared/share/moon.yml # src/platform/plugins/shared/share/public/components/share_context_menu.tsx # src/platform/plugins/shared/share/public/components/tabs/link/time_type_section.tsx # src/platform/plugins/shared/share/public/components/url_panel_content.tsx # src/platform/plugins/shared/share/tsconfig.json
kowalczyk-krzysztof
added a commit
that referenced
this pull request
Dec 10, 2025
…) (#245846) # Backport This will backport the following commits from `main` to `8.19`: - [Fix "now" and mixed format date handling in share modal (#245539)](#245539) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-10T14:12:00Z","message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","papercut","v9.3.0"],"title":"Fix \"now\" and mixed format date handling in share modal","number":245539,"url":"https://github.com/elastic/kibana/pull/245539","mergeCommit":{"message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245539","number":245539,"mergeCommit":{"message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262"}},{"url":"https://github.com/elastic/kibana/pull/245841","number":245841,"branch":"9.2","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/245845","number":245845,"branch":"9.1","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kowalczyk-krzysztof
added a commit
that referenced
this pull request
Dec 10, 2025
… (#245841) # Backport This will backport the following commits from `main` to `9.2`: - [Fix "now" and mixed format date handling in share modal (#245539)](#245539) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-10T14:12:00Z","message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","papercut","v9.3.0"],"title":"Fix \"now\" and mixed format date handling in share modal","number":245539,"url":"https://github.com/elastic/kibana/pull/245539","mergeCommit":{"message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245539","number":245539,"mergeCommit":{"message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262"}}]}] BACKPORT-->
kowalczyk-krzysztof
added a commit
that referenced
this pull request
Dec 10, 2025
… (#245845) # Backport This will backport the following commits from `main` to `9.1`: - [Fix "now" and mixed format date handling in share modal (#245539)](#245539) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-10T14:12:00Z","message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","papercut","v9.3.0"],"title":"Fix \"now\" and mixed format date handling in share modal","number":245539,"url":"https://github.com/elastic/kibana/pull/245539","mergeCommit":{"message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245539","number":245539,"mergeCommit":{"message":"Fix \"now\" and mixed format date handling in share modal (#245539)\n\n## Summary\n\nThis PR fixes a bug where mixed dates (e.g one absolute and one\nrelative) wouldn't work properly and \"now\" was rendering as 0 seconds in\nshare modal date switcher.\n\n<img width=\"494\" height=\"432\" alt=\"Screenshot 2025-12-09 at 13 13 05\"\nsrc=\"https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a\"\n/>\n\n\nIt also makes `ShareableUrlLocatorParams` strongly typed, requiring\n`timeRange` to be always present even if it has an undefined value, in\nresponse to a regression where dashboard time range parameter name was\nrenamed to be snake_case, which broke the functionality as\n`TimeTypeSection` would always expect `timeRange`.\n\nCloses: https://github.com/elastic/kibana/issues/241084\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bae752eb63e5e899019ab4a063a02d2f92815262"}},{"url":"https://github.com/elastic/kibana/pull/245841","number":245841,"branch":"9.2","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where mixed dates (e.g one absolute and one relative) wouldn't work properly and "now" was rendering as 0 seconds in share modal date switcher.
It also makes
ShareableUrlLocatorParamsstrongly typed, requiringtimeRangeto be always present even if it has an undefined value, in response to a regression where dashboard time range parameter name was renamed to be snake_case, which broke the functionality asTimeTypeSectionwould always expecttimeRange.Closes: #241084