[8.19] Fix "now" and mixed format date handling in share modal (#245539)#245846
Merged
kowalczyk-krzysztof merged 3 commits intoelastic:8.19from Dec 10, 2025
Merged
Conversation
## Summary This PR fixes a bug where mixed dates (e.g one absolute and one relative) wouldn't work properly and "now" was rendering as 0 seconds in share modal date switcher. <img width="494" height="432" alt="Screenshot 2025-12-09 at 13 13 05" src="https://github.com/user-attachments/assets/4d5eb332-7329-40be-b725-97cf5020b73a" /> It also makes `ShareableUrlLocatorParams` strongly typed, requiring `timeRange` to be always present even if it has an undefined value, in response to a regression where dashboard time range parameter name was renamed to be snake_case, which broke the functionality as `TimeTypeSection` would always expect `timeRange`. Closes: elastic#241084 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bae752e) # Conflicts: # src/platform/plugins/shared/discover/public/application/main/components/top_nav/app_menu_actions/get_share.tsx # src/platform/plugins/shared/share/moon.yml # src/platform/plugins/shared/share/public/components/share_context_menu.tsx # src/platform/plugins/shared/share/public/components/tabs/link/time_type_section.tsx # src/platform/plugins/shared/share/public/components/url_panel_content.tsx # src/platform/plugins/shared/share/tsconfig.json
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation