Fix case sensitivity of fields in role page#246069
Merged
jeramysoucy merged 6 commits intoelastic:mainfrom Dec 16, 2025
Merged
Conversation
jeramysoucy
added
bug
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
| }, | ||
| }); | ||
|
|
||
| await PageObjects.common.sleep(1000); |
Contributor
There was a problem hiding this comment.
just curious why this sleep is necessary?
Contributor
Author
There was a problem hiding this comment.
++ I am not sure that it is. The other tests in this suite also contain this, so I did the same. We could investigate whether this is necessary or overkill though - I wonder if a much shorter pause (or no pause) would be sufficient.
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 16, 2025
Closes elastic#244000 ## Summary This PR makes the index privileges field combos on the Edit Role page case sensitive to correlate to how fields are handled in Elasticsearch. ### Screenshots <img width="914" height="336" alt="Screenshot 2025-12-11 at 14 33 58" src="https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234" /> <img width="911" height="338" alt="Screenshot 2025-12-11 at 14 33 02" src="https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb" /> ### Tests - x-pack/platform/test/functional/apps/security/field_level_security.ts ## Release note Fixes an issue where fields were not case-sensitive in Kibana's user interface for creating and updating roles, though fields are case-sensitive in Elasticsearch. (cherry picked from commit c4e2c1f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 16, 2025
Closes elastic#244000 ## Summary This PR makes the index privileges field combos on the Edit Role page case sensitive to correlate to how fields are handled in Elasticsearch. ### Screenshots <img width="914" height="336" alt="Screenshot 2025-12-11 at 14 33 58" src="https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234" /> <img width="911" height="338" alt="Screenshot 2025-12-11 at 14 33 02" src="https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb" /> ### Tests - x-pack/platform/test/functional/apps/security/field_level_security.ts ## Release note Fixes an issue where fields were not case-sensitive in Kibana's user interface for creating and updating roles, though fields are case-sensitive in Elasticsearch. (cherry picked from commit c4e2c1f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 16, 2025
Closes elastic#244000 ## Summary This PR makes the index privileges field combos on the Edit Role page case sensitive to correlate to how fields are handled in Elasticsearch. ### Screenshots <img width="914" height="336" alt="Screenshot 2025-12-11 at 14 33 58" src="https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234" /> <img width="911" height="338" alt="Screenshot 2025-12-11 at 14 33 02" src="https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb" /> ### Tests - x-pack/platform/test/functional/apps/security/field_level_security.ts ## Release note Fixes an issue where fields were not case-sensitive in Kibana's user interface for creating and updating roles, though fields are case-sensitive in Elasticsearch. (cherry picked from commit c4e2c1f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 16, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [Fix case sensitivity of fields in role page (#246069)](#246069) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-12-16T21:38:29Z","message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","backport:all-open","v9.3.0"],"title":"Fix case sensitivity of fields in role page","number":246069,"url":"https://github.com/elastic/kibana/pull/246069","mergeCommit":{"message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246069","number":246069,"mergeCommit":{"message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Dec 16, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Fix case sensitivity of fields in role page (#246069)](#246069) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-12-16T21:38:29Z","message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","backport:all-open","v9.3.0"],"title":"Fix case sensitivity of fields in role page","number":246069,"url":"https://github.com/elastic/kibana/pull/246069","mergeCommit":{"message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246069","number":246069,"mergeCommit":{"message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
kibanamachine
added
v8.19.9
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2025
# Backport This will backport the following commits from `main` to `9.2`: - [Fix case sensitivity of fields in role page (#246069)](#246069) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-12-16T21:38:29Z","message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","backport:all-open","v9.3.0"],"title":"Fix case sensitivity of fields in role page","number":246069,"url":"https://github.com/elastic/kibana/pull/246069","mergeCommit":{"message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246069","number":246069,"mergeCommit":{"message":"Fix case sensitivity of fields in role page (#246069)\n\nCloses #244000\n\n## Summary\n\nThis PR makes the index privileges field combos on the Edit Role page\ncase sensitive to correlate to how fields are handled in Elasticsearch.\n\n### Screenshots\n<img width=\"914\" height=\"336\" alt=\"Screenshot 2025-12-11 at 14 33 58\"\nsrc=\"https://github.com/user-attachments/assets/dcd0b4a8-4cb1-4216-a4d9-83ec0bdb7234\"\n/>\n\n<img width=\"911\" height=\"338\" alt=\"Screenshot 2025-12-11 at 14 33 02\"\nsrc=\"https://github.com/user-attachments/assets/c9bd09a4-4a44-4d9a-ac74-1aff6be006eb\"\n/>\n\n### Tests\n- x-pack/platform/test/functional/apps/security/field_level_security.ts\n\n## Release note\nFixes an issue where fields were not case-sensitive in Kibana's user\ninterface for creating and updating roles, though fields are\ncase-sensitive in Elasticsearch.","sha":"c4e2c1f12b8dad3a96b8d991c29b6226f7e93c86"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
kibanamachine
added
v9.2.3
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244000
Summary
This PR makes the index privileges field combos on the Edit Role page case sensitive to correlate to how fields are handled in Elasticsearch.
Screenshots
Tests
Release note
Fixes an issue where fields were not case-sensitive in Kibana's user interface for creating and updating roles, though fields are case-sensitive in Elasticsearch.