Skip to content

Fix case sensitivity of fields in role page #246069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeramysoucy merged 6 commits into from
Dec 16, 2025
Merged

Fix case sensitivity of fields in role page #246069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b80640
Makes combos case sensative
jeramysoucy Dec 11, 2025
ac6acb9
Updates functional tests
jeramysoucy Dec 11, 2025
8d64dc2
Merge branch 'main' into fix-field-case-sensitivity
jeramysoucy Dec 11, 2025
3182ee2
Merge branch 'main' into fix-field-case-sensitivity
jeramysoucy Dec 12, 2025
3e75e44
Fixes test failure
jeramysoucy Dec 16, 2025
e6e7235
Merge branch 'main' into fix-field-case-sensitivity
jeramysoucy Dec 16, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../shared/security/public/management/roles/edit_role/privileges/es/index_privilege_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ export class IndexPrivilegeForm extends Component<Props, State> {
{ defaultMessage: 'Add a field pattern…' }
)}
fullWidth
isCaseSensitive
/>
</EuiFormRow>
</EuiFlexItem>
Expand Down Expand Up @@ -368,6 +369,7 @@ export class IndexPrivilegeForm extends Component<Props, State> {
{ defaultMessage: 'Add a field pattern…' }
)}
fullWidth
isCaseSensitive
/>
</EuiFormRow>
</EuiFlexItem>
Expand Down
56 changes: 56 additions & 0 deletions x-pack/platform/test/functional/apps/security/field_level_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,62 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(rowData).not.to.contain('ssn');
});

it('should support case-sensitive fields', async function () {
await PageObjects.security.forceLogout();
await PageObjects.security.login();
await PageObjects.settings.navigateTo();
await PageObjects.security.clickElasticsearchRoles();
await PageObjects.security.addRole('a_casesenstive_fields_role', {
elasticsearch: {
indices: [
{
names: ['flstest'],
privileges: ['read', 'view_index_metadata'],
field_security: {
grant: ['customer_*', 'Customer_*'],
except: ['customer_region', 'Customer_region'],
},
},
],
},
});

await PageObjects.common.sleep(1000);
Copy link
Contributor

@rgodfrey-elastic rgodfrey-elastic Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why this sleep is necessary?
Copy link
Contributor Author

@jeramysoucy jeramysoucy Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ I am not sure that it is. The other tests in this suite also contain this, so I did the same. We could investigate whether this is necessary or overkill though - I wonder if a much shorter pause (or no pause) would be sufficient.

const roleDef = await security.role.get('a_casesenstive_fields_role');
expect(roleDef).to.eql({
_transform_error: [],
_unrecognized_applications: [],
elasticsearch: {
cluster: [],
indices: [
{
allow_restricted_indices: false,
field_security: {
except: ['customer_region', 'Customer_region'],
grant: ['customer_*', 'Customer_*'],
},
names: ['flstest'],
privileges: ['read', 'view_index_metadata'],
},
],
run_as: [],
},
kibana: [
{
base: ['all'],
feature: {},
spaces: ['*'],
},
],
metadata: {},
name: 'a_casesenstive_fields_role',
transient_metadata: {
enabled: true,
},
});
});

after(async function () {
// NOTE: Logout needs to happen before anything else to avoid flaky behavior
await PageObjects.security.forceLogout();
Expand Down
9 changes: 9 additions & 0 deletions x-pack/platform/test/functional/page_objects/security_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,12 @@ export class SecurityPageObject extends FtrService {
}
};

const addDeniedField = async (fields: string[]) => {
for (const entry of fields) {
await this.comboBox.setCustom('deniedFieldInput0', entry);
}
};

// clicking the Granted fields and removing the asterix
if (roleObj.elasticsearch.indices[0].field_security) {
// Toggle FLS switch
Expand All @@ -730,6 +736,9 @@ export class SecurityPageObject extends FtrService {
);

await addGrantedField(roleObj.elasticsearch.indices[0].field_security!.grant!);
if (roleObj.elasticsearch.indices[0].field_security?.except) {
await addDeniedField(roleObj.elasticsearch.indices[0].field_security.except);
}
}

if (roleObj.elasticsearch.remote_cluster) {
Expand Down