Skip to content

[Lens][Data Table] Fix link's color contrast#247721

Merged
maryam-saeidi merged 4 commits intoelastic:mainfrom
maryam-saeidi:242181-fix-dark-link-color
Jan 7, 2026
Merged

[Lens][Data Table] Fix link's color contrast#247721
maryam-saeidi merged 4 commits intoelastic:mainfrom
maryam-saeidi:242181-fix-dark-link-color

Conversation

@maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Jan 2, 2026

Fixes #242181

Summary

This PR adjust the link text color when 'Direct Filter On Click' is enabled to have mode contrast with the background, using makeHighContrastColor with euiTheme.colors.link in light mode and euiTheme.colors.highlight in dark mode.

Color palette Before After
Elastic classic image image
Kibana 4.0 image image
Elastic image image
Kibana 7.0 image image
Screen.Recording.2025-12-31.at.17.25.06.mov
@maryam-saeidi maryam-saeidi self-assigned this Jan 2, 2026
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner January 2, 2026 09:52
@maryam-saeidi maryam-saeidi added the backport:skip This PR does not require backporting label Jan 2, 2026
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks great to me! 🎉

@markov00 @gvnmagni WDYT?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.9MB 1.9MB +160.0B

History

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 11291ce into elastic:main Jan 7, 2026
14 checks passed
@maryam-saeidi maryam-saeidi deleted the 242181-fix-dark-link-color branch January 7, 2026 13:53
@maryam-saeidi maryam-saeidi changed the title [Lens][Data Table] Fix 'Direct Filter On Click' link color in dark mode Jan 7, 2026
@maryam-saeidi maryam-saeidi added backport:all-open Backport to all branches that could still receive a release and removed backport:skip This PR does not require backporting labels Jan 7, 2026
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/20786163920

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/20786164195

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|

https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11291ce)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|

https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11291ce)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts
9.2
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 247721

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|

https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11291ce)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|

https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11291ce)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts
9.2
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 247721

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 7, 2026
…ark mode (#247721) (#248112)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Lens][Data Table] Fix 'Direct Filter On Click' link color in dark
mode (#247721)](#247721)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2026-01-07T09:01:35Z","message":"[Lens][Data
Table] Fix 'Direct Filter On Click' link color in dark mode
(#247721)\n\nFixes https://github.com/elastic/kibana/issues/242181\n\n##
Summary\n\nThis PR adjust the link text color when 'Direct Filter On
Click' is\nenabled to have mode contrast with the background,
using\n`makeHighContrastColor` with `euiTheme.colors.link` in light mode
and\n`euiTheme.colors.highlight` in dark mode.\n\n|Color
palette|Before|After|\n|---|---|---|\n|Elastic classic|<img
width=\"792\" height=\"459\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7\"\n/>|<img
width=\"801\" height=\"466\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd\"\n/>|\n|Kibana
4.0|<img width=\"792\" height=\"456\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774\"\n/>|<img
width=\"791\" height=\"458\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21\"\n/>|\n|Elastic|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f\"\n/>|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399\"\n/>|\n|Kibana
7.0|<img width=\"792\" height=\"460\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b\"\n/>|<img
width=\"795\" height=\"455\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9\"\n/>|\n\n\n\nhttps://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11291ce6a213264487cd1b86f50ee67b7cdc9dd7","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v9.4.0"],"title":"[Lens][Data
Table] Fix link's color
contrast","number":247721,"url":"https://github.com/elastic/kibana/pull/247721","mergeCommit":{"message":"[Lens][Data
Table] Fix 'Direct Filter On Click' link color in dark mode
(#247721)\n\nFixes https://github.com/elastic/kibana/issues/242181\n\n##
Summary\n\nThis PR adjust the link text color when 'Direct Filter On
Click' is\nenabled to have mode contrast with the background,
using\n`makeHighContrastColor` with `euiTheme.colors.link` in light mode
and\n`euiTheme.colors.highlight` in dark mode.\n\n|Color
palette|Before|After|\n|---|---|---|\n|Elastic classic|<img
width=\"792\" height=\"459\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7\"\n/>|<img
width=\"801\" height=\"466\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd\"\n/>|\n|Kibana
4.0|<img width=\"792\" height=\"456\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774\"\n/>|<img
width=\"791\" height=\"458\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21\"\n/>|\n|Elastic|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f\"\n/>|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399\"\n/>|\n|Kibana
7.0|<img width=\"792\" height=\"460\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b\"\n/>|<img
width=\"795\" height=\"455\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9\"\n/>|\n\n\n\nhttps://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11291ce6a213264487cd1b86f50ee67b7cdc9dd7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247721","number":247721,"mergeCommit":{"message":"[Lens][Data
Table] Fix 'Direct Filter On Click' link color in dark mode
(#247721)\n\nFixes https://github.com/elastic/kibana/issues/242181\n\n##
Summary\n\nThis PR adjust the link text color when 'Direct Filter On
Click' is\nenabled to have mode contrast with the background,
using\n`makeHighContrastColor` with `euiTheme.colors.link` in light mode
and\n`euiTheme.colors.highlight` in dark mode.\n\n|Color
palette|Before|After|\n|---|---|---|\n|Elastic classic|<img
width=\"792\" height=\"459\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7\"\n/>|<img
width=\"801\" height=\"466\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd\"\n/>|\n|Kibana
4.0|<img width=\"792\" height=\"456\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774\"\n/>|<img
width=\"791\" height=\"458\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21\"\n/>|\n|Elastic|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f\"\n/>|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399\"\n/>|\n|Kibana
7.0|<img width=\"792\" height=\"460\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b\"\n/>|<img
width=\"795\" height=\"455\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9\"\n/>|\n\n\n\nhttps://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11291ce6a213264487cd1b86f50ee67b7cdc9dd7"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
kibanamachine added a commit that referenced this pull request Jan 7, 2026
…ark mode (#247721) (#248111)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[Lens][Data Table] Fix 'Direct Filter On Click' link color in dark
mode (#247721)](#247721)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2026-01-07T09:01:35Z","message":"[Lens][Data
Table] Fix 'Direct Filter On Click' link color in dark mode
(#247721)\n\nFixes https://github.com/elastic/kibana/issues/242181\n\n##
Summary\n\nThis PR adjust the link text color when 'Direct Filter On
Click' is\nenabled to have mode contrast with the background,
using\n`makeHighContrastColor` with `euiTheme.colors.link` in light mode
and\n`euiTheme.colors.highlight` in dark mode.\n\n|Color
palette|Before|After|\n|---|---|---|\n|Elastic classic|<img
width=\"792\" height=\"459\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7\"\n/>|<img
width=\"801\" height=\"466\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd\"\n/>|\n|Kibana
4.0|<img width=\"792\" height=\"456\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774\"\n/>|<img
width=\"791\" height=\"458\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21\"\n/>|\n|Elastic|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f\"\n/>|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399\"\n/>|\n|Kibana
7.0|<img width=\"792\" height=\"460\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b\"\n/>|<img
width=\"795\" height=\"455\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9\"\n/>|\n\n\n\nhttps://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11291ce6a213264487cd1b86f50ee67b7cdc9dd7","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v9.4.0"],"title":"[Lens][Data
Table] Fix link's color
contrast","number":247721,"url":"https://github.com/elastic/kibana/pull/247721","mergeCommit":{"message":"[Lens][Data
Table] Fix 'Direct Filter On Click' link color in dark mode
(#247721)\n\nFixes https://github.com/elastic/kibana/issues/242181\n\n##
Summary\n\nThis PR adjust the link text color when 'Direct Filter On
Click' is\nenabled to have mode contrast with the background,
using\n`makeHighContrastColor` with `euiTheme.colors.link` in light mode
and\n`euiTheme.colors.highlight` in dark mode.\n\n|Color
palette|Before|After|\n|---|---|---|\n|Elastic classic|<img
width=\"792\" height=\"459\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7\"\n/>|<img
width=\"801\" height=\"466\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd\"\n/>|\n|Kibana
4.0|<img width=\"792\" height=\"456\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774\"\n/>|<img
width=\"791\" height=\"458\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21\"\n/>|\n|Elastic|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f\"\n/>|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399\"\n/>|\n|Kibana
7.0|<img width=\"792\" height=\"460\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b\"\n/>|<img
width=\"795\" height=\"455\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9\"\n/>|\n\n\n\nhttps://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11291ce6a213264487cd1b86f50ee67b7cdc9dd7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247721","number":247721,"mergeCommit":{"message":"[Lens][Data
Table] Fix 'Direct Filter On Click' link color in dark mode
(#247721)\n\nFixes https://github.com/elastic/kibana/issues/242181\n\n##
Summary\n\nThis PR adjust the link text color when 'Direct Filter On
Click' is\nenabled to have mode contrast with the background,
using\n`makeHighContrastColor` with `euiTheme.colors.link` in light mode
and\n`euiTheme.colors.highlight` in dark mode.\n\n|Color
palette|Before|After|\n|---|---|---|\n|Elastic classic|<img
width=\"792\" height=\"459\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7\"\n/>|<img
width=\"801\" height=\"466\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd\"\n/>|\n|Kibana
4.0|<img width=\"792\" height=\"456\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774\"\n/>|<img
width=\"791\" height=\"458\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21\"\n/>|\n|Elastic|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f\"\n/>|<img
width=\"793\" height=\"457\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399\"\n/>|\n|Kibana
7.0|<img width=\"792\" height=\"460\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b\"\n/>|<img
width=\"795\" height=\"455\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9\"\n/>|\n\n\n\nhttps://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11291ce6a213264487cd1b86f50ee67b7cdc9dd7"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
@maryam-saeidi
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|



https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
maryam-saeidi added a commit to maryam-saeidi/kibana that referenced this pull request Jan 8, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|

https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11291ce)

# Conflicts:
#	x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/cell_value.tsx
@maryam-saeidi
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 9, 2026
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @maryam-saeidi

devamanv pushed a commit to devamanv/kibana that referenced this pull request Jan 12, 2026
…de (elastic#247721)

Fixes elastic#242181

## Summary

This PR adjust the link text color when 'Direct Filter On Click' is
enabled to have mode contrast with the background, using
`makeHighContrastColor` with `euiTheme.colors.link` in light mode and
`euiTheme.colors.highlight` in dark mode.

|Color palette|Before|After|
|---|---|---|
|Elastic classic|<img width="792" height="459" alt="image"
src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7"
/>|<img width="801" height="466" alt="image"
src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd"
/>|
|Kibana 4.0|<img width="792" height="456" alt="image"
src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774"
/>|<img width="791" height="458" alt="image"
src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21"
/>|
|Elastic|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f"
/>|<img width="793" height="457" alt="image"
src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399"
/>|
|Kibana 7.0|<img width="792" height="460" alt="image"
src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b"
/>|<img width="795" height="455" alt="image"
src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9"
/>|



https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @maryam-saeidi

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @maryam-saeidi

@maryam-saeidi maryam-saeidi added backport:version Backport to applied version labels and removed backport:all-open Backport to all branches that could still receive a release labels Jan 14, 2026
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/20987725778

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.2 Backport failed because of merge conflicts
9.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 247721

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants