[9.1] [Lens][Data Table] Fix 'Direct Filter On Click' link color in dark mode (#247721)#248284
Closed
maryam-saeidi wants to merge 1 commit intoelastic:9.1from
Closed
[9.1] [Lens][Data Table] Fix 'Direct Filter On Click' link color in dark mode (#247721)#248284maryam-saeidi wants to merge 1 commit intoelastic:9.1from
maryam-saeidi wants to merge 1 commit intoelastic:9.1from
Conversation
…de (elastic#247721) Fixes elastic#242181 ## Summary This PR adjust the link text color when 'Direct Filter On Click' is enabled to have mode contrast with the background, using `makeHighContrastColor` with `euiTheme.colors.link` in light mode and `euiTheme.colors.highlight` in dark mode. |Color palette|Before|After| |---|---|---| |Elastic classic|<img width="792" height="459" alt="image" src="https://github.com/user-attachments/assets/dd53dea6-ddf5-4a60-85e1-cd0dec5192d7" />|<img width="801" height="466" alt="image" src="https://github.com/user-attachments/assets/68a9e6fe-6a2e-4f4b-82f7-322bcc72decd" />| |Kibana 4.0|<img width="792" height="456" alt="image" src="https://github.com/user-attachments/assets/813cf8a0-959b-452e-a847-06f7fddde774" />|<img width="791" height="458" alt="image" src="https://github.com/user-attachments/assets/5ca137a0-8c5c-42e4-83a1-7ae3ff91dc21" />| |Elastic|<img width="793" height="457" alt="image" src="https://github.com/user-attachments/assets/bb558474-de9b-4eb0-8d7c-cdbb9895f82f" />|<img width="793" height="457" alt="image" src="https://github.com/user-attachments/assets/97189120-7050-4bea-a182-555666c65399" />| |Kibana 7.0|<img width="792" height="460" alt="image" src="https://github.com/user-attachments/assets/49aae99f-119f-4978-8849-a3d83e833e1b" />|<img width="795" height="455" alt="image" src="https://github.com/user-attachments/assets/c7d70935-b97a-41b1-82db-01a58b6ad5c9" />| https://github.com/user-attachments/assets/cf2e1c5a-1c93-490e-ba3b-f59a9379c82c --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 11291ce) # Conflicts: # x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/cell_value.tsx
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation