Consolidate JSON stringify dependencies by legrego · Pull Request #251890 · elastic/kibana

legrego · 2026-02-05T12:52:58Z

Moves all JSON stringification under @kbn/std where we already had an existing stringification utility. This also consolidates the implementation to a single third-party dependency, instead of 3.

Important

Please test your UIs! Tests may not catch all regressions!

Consolidate JSON Stringification Dependencies

Background

The issue #233194 requests consolidating JSON stringification dependencies. After analysis:

Dependency	Usages	Purpose	Action
json-stable-stringify	23 files	Deterministic/sorted keys for hashing	Replace with @kbn/std
json-stringify-safe	1 file	Handle circular references	Replace with @kbn/std
json-stringify-pretty-compact	2 files	Pretty-print with max line length	Replace with @kbn/std

Solution: Extend `@kbn/std` Package

Extend the existing @kbn/std package with new JSON stringify utilities, backed by safe-stable-stringify which handles both circular references AND deterministic ordering.

Why @kbn/std?

Already has related utilities: safeJsonParse, safeJsonStringify
Widely used core package for general utilities
Avoids creating a new single-purpose package

Files to Modify in `@kbn/std`

src/platform/packages/shared/kbn-std/
  ├── package.json              # Add safe-stable-stringify dependency
  ├── index.ts                  # Export new functions
  └── src/
      ├── safe_json_stringify.ts    # Enhance to handle circular refs
      ├── stable_stringify.ts       # NEW: Deterministic stringify
      └── pretty_compact_stringify.ts  # NEW: Pretty-print with max line length

Purpose: What is this dependency used for? Briefly explain its role in your changes.
This is used for both stable and safe JSON stringification. It was already included as a transitive dependency. This promotes it to a top-level dependency.

Justification: Why is adding this dependency the best approach?
It allows us to consolidate JSON stringification use cases down to a single dependency.

…/json-stringify

The consolidation work changed from json-stable-stringify to safe-stable-stringify. These libraries format empty arrays differently: json-stable-stringify: Empty arrays span 2 lines ([\n]) safe-stable-stringify: Empty arrays are inline ([]) This results in 9 fewer lines (49 vs 40), which matches the test discrepancy (44 vs 35 unchanged lines).

kibanamachine · 2026-02-05T19:14:13Z

Dependency Review Bot Analysis 🔍

Found 1 new third-party dependencies:

Package	Version	Vulnerabilities	Health Score
safe-stable-stringify	2.5.0	🔴 C: 0, 🟠 H: 0, 🟡 M: 0, 🟢 L: 0

Self Checklist

To help with the review, please update the PR description to address the following points for each new third-party dependency listed above:

Purpose: What is this dependency used for? Briefly explain its role in your changes.
Justification: Why is adding this dependency the best approach?
Alternatives explored: Were other options considered (e.g., using existing internal libraries/utilities, implementing the functionality directly)? If so, why was this dependency chosen over them?
Existing dependencies: Does Kibana have a dependency providing similar functionality? If so, why is the new one preferred?

Thank you for providing this information!

jbudz

packages/kbn-optimizer/src/optimizer/diff_cache_key.ts LGTM

pmuellr

ResponseOps changes LGTM

afharo

Core changes LGTM

davismcphee

Data Discovery changes LGTM 👍

azasypkin

Changes in ESO plugin, LGTM, thanks!

weltenwort · 2026-02-06T10:15:32Z

/oblt-deploy

weltenwort

obs-exploration changes LGTM

sabarasaba

kibana management changes lgtm

markov00

Lovely, thanks @legrego
LGTM

legrego · 2026-02-09T11:57:45Z

@elasticmachine merge upstream

rmyz

obs presentation changes LGTM

christineweng

Cases changes LGTM, code review only

nikitaindik

Found a minor visual regression in our diff UI when reviewing. While the diff is still technically correct, it now looks noisier in cases where an empty array becomes non-empty, or vice versa.

Old implementation

Unified view screenshots

Split view screenshots

This PR

Unified view screenshots

Split view screenshots

Let me take another look at it tomorrow and get back to you. As a raw idea, I guess we could pre-process JSONs to expand "[]" to "[\n]".

nikitaindik

@legrego I pushed a commit with the fix. The diff UI now looks same as before. Feel free to merge once it builds.

legrego · 2026-02-10T12:17:53Z

@nikitaindik I really appreciate the review and code changes. Thanks!

legrego · 2026-02-10T12:20:44Z

@elasticmachine merge upstream

elasticmachine · 2026-02-10T13:55:29Z

⏳ Build in-progress

Buildkite Build
Commit: b186e26
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-251890-b186e26e46a8

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #10 / Alerting alerts_as_data alerts as data delay should not recover alert if the activeCount did not reach the alertDelay threshold with AAD
[job] [logs] FTR Configs #71 / serverless observability UI - telemetry discover/observabilitySolution/context_awareness/telemetry telemetry context should set EBT context for telemetry events when logs data source profile and reset

History

💔 Build #392351 failed 1c8d481
💛 Build #391760 was flaky 597cc80
💛 Build #390582 was flaky 191e915
💔 Build #390491 failed 9aa8dc0
💔 Build #390400 failed bfec507
💔 Build #390381 failed f190772

* commit '7dcc1fe3c205d2de0c3ca3f65804f21de09013c3': (285 commits) Enrich kbn-check-saved-objects-cli README with CI and manual usage docs (elastic#252557) [Discover] Add feature flag to make ESQL the default query mode (elastic#252268) Add maskProps.headerZindexLocation above to inspect component flyout (elastic#252543) [Security Solution][Atack/Alerts] Flyout header: Assignees (elastic#252190) Upgrade EUI to v112.3.0 (elastic#252315) [Fleet] Make save_knowledge_base async in streaming state machine (elastic#252328) Upgrade @smithy/config-resolver 4.3.0 → 4.4.6 (elastic#252457) [Lens as API] Add colorMapping support for XY charts (ES|QL data layers) (elastic#252051) [WorkplaceAI] Add Google Drive data source and connector (elastic#250677) [Scout] Move GlobalSearch FTR tests to Scout (elastic#252201) [EDR Workflows] Fix osquery pack results display when agent clock is skewed (elastic#251417) [Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV (elastic#252486) [Entity Analytics] Update `host.ip` aggregation to remove painless script (elastic#252426) Address `@elastic/eui/require-table-caption` lint violations across `@elastic/obs-presentation-team` files (elastic#251050) Consolidate JSON stringify dependencies (elastic#251890) [index mgmt] Use esql instead of query dsl to get the index count (elastic#252422) Add Usage API Plugin (elastic#252434) Cases All Templates page (elastic#250372) [Agent Builder] Default value for optional params in ESQL tools (elastic#238472) [Fleet] Add upgrade_details.metadata.reason to AgentResponseSchema (elastic#252485) ...

legrego and others added 12 commits February 5, 2026 07:51

Consolidate JSON stringify dependencies

ff32a82

Update renovate.json

f190772

Changes from yarn openapi:bundle

bfec507

update yarn.lock:

8e93cb5

Merge branch 'dr/json-stringify' of github.com:legrego/kibana into dr…

57a04e9

…/json-stringify

Changes from node scripts/lint_ts_projects --fix

3074422

Changes from security: 3rd-party dependencies

9283c08

Changes from node scripts/regenerate_moon_projects.js --update

e1f1aff

Changes from node scripts/eslint_all_files --no-cache --fix

9aa8dc0

Merge branch 'dr/json-stringify' of github.com:legrego/kibana into dr…

d257b02

…/json-stringify

Merge branch 'main' of github.com:elastic/kibana into dr/json-stringify

191e915

legrego marked this pull request as ready for review February 5, 2026 19:13

legrego requested review from a team as code owners February 5, 2026 19:13

legrego requested review from azasypkin and nikitaindik February 5, 2026 19:13

jbudz approved these changes Feb 5, 2026

View reviewed changes

pmuellr approved these changes Feb 5, 2026

View reviewed changes

afharo approved these changes Feb 5, 2026

View reviewed changes

davismcphee approved these changes Feb 6, 2026

View reviewed changes

csr approved these changes Feb 6, 2026

View reviewed changes

azasypkin approved these changes Feb 6, 2026

View reviewed changes

weltenwort self-requested a review February 6, 2026 10:22

weltenwort approved these changes Feb 6, 2026

View reviewed changes

sabarasaba approved these changes Feb 6, 2026

View reviewed changes

markov00 approved these changes Feb 9, 2026

View reviewed changes

markov00 mentioned this pull request Feb 9, 2026

Update dependency json-stringify-pretty-compact to v3 (main) #236126

Closed

1 task

Merge branch 'main' into dr/json-stringify

597cc80

rmyz approved these changes Feb 9, 2026

View reviewed changes

viduni94 approved these changes Feb 9, 2026

View reviewed changes

christineweng approved these changes Feb 9, 2026

View reviewed changes

legrego enabled auto-merge (squash) February 9, 2026 15:54

nikitaindik reviewed Feb 9, 2026

View reviewed changes

Expand empties

1c8d481

nikitaindik approved these changes Feb 10, 2026

View reviewed changes

Merge branch 'main' into dr/json-stringify

b186e26

legrego merged commit 0c9ebf5 into elastic:main Feb 10, 2026
18 checks passed

kibanamachine added the v9.4.0 label Feb 10, 2026

legrego deleted the dr/json-stringify branch February 10, 2026 16:24

tonyghiani mentioned this pull request Feb 11, 2026

[Fields Metadata] Update dependency @elastic/ecs to ^9.2.0 and optimize bundle #245798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate JSON stringify dependencies#251890

Consolidate JSON stringify dependencies#251890
legrego merged 15 commits intoelastic:mainfrom
legrego:dr/json-stringify

legrego commented Feb 5, 2026 •

edited

Loading

kibanamachine commented Feb 5, 2026

jbudz left a comment

pmuellr left a comment

afharo left a comment

davismcphee left a comment

azasypkin left a comment

weltenwort commented Feb 6, 2026

weltenwort left a comment

sabarasaba left a comment

markov00 left a comment

legrego commented Feb 9, 2026

rmyz left a comment

christineweng left a comment

nikitaindik left a comment

nikitaindik left a comment

legrego commented Feb 10, 2026

legrego commented Feb 10, 2026

elasticmachine commented Feb 10, 2026

Uh oh!

Labels

16 participants

Conversation

legrego commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Consolidate JSON Stringification Dependencies

Background

Solution: Extend @kbn/std Package

Files to Modify in @kbn/std

kibanamachine commented Feb 5, 2026

Self Checklist

jbudz left a comment

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

azasypkin left a comment

Choose a reason for hiding this comment

weltenwort commented Feb 6, 2026

weltenwort left a comment

Choose a reason for hiding this comment

sabarasaba left a comment

Choose a reason for hiding this comment

markov00 left a comment

Choose a reason for hiding this comment

legrego commented Feb 9, 2026

rmyz left a comment

Choose a reason for hiding this comment

christineweng left a comment

Choose a reason for hiding this comment

nikitaindik left a comment

Choose a reason for hiding this comment

Old implementation

This PR

nikitaindik left a comment

Choose a reason for hiding this comment

legrego commented Feb 10, 2026

legrego commented Feb 10, 2026

elasticmachine commented Feb 10, 2026

⏳ Build in-progress

Failed CI Steps

Test Failures

History

Uh oh!

Labels

16 participants

legrego commented Feb 5, 2026 •

edited

Loading

Solution: Extend `@kbn/std` Package

Files to Modify in `@kbn/std`