Skip to content

[Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV#252486

Merged
rStelmach merged 2 commits intoelastic:mainfrom
rStelmach:252464-observability-onboarding-integrationsinstall-hard-limit-100
Feb 10, 2026
Merged

[Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV#252486
rStelmach merged 2 commits intoelastic:mainfrom
rStelmach:252464-observability-onboarding-integrationsinstall-hard-limit-100

Conversation

@rStelmach
Copy link
Contributor

@rStelmach rStelmach commented Feb 10, 2026

Summary

Closes #252464

Moves the MAX_INTEGRATIONS_LIMIT check in parseIntegrationsTSV to run after the merge/dedup step instead of before it. Previously the limit was applied to raw TSV lines, which counted each custom log file path as a separate entry, even though multiple paths from the same directory are merged into a single integration. This caused legitimate requests to be rejected when hosts had many custom log paths (e.g. 179 lines that would collapse to far fewer actual integrations).

The limit should now correctly count unique integrations rather than raw input lines.

@rStelmach rStelmach marked this pull request as ready for review February 10, 2026 10:40
@rStelmach rStelmach requested a review from a team as a code owner February 10, 2026 10:40
@rStelmach rStelmach added release_note:fix backport:skip This PR does not require backporting Team:obs-onboarding Observability Onboarding Team labels Feb 10, 2026
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-onboarding-team (Team:obs-onboarding)

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rStelmach rStelmach merged commit 773db33 into elastic:main Feb 10, 2026
16 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 10, 2026
* commit '7dcc1fe3c205d2de0c3ca3f65804f21de09013c3': (285 commits)
  Enrich kbn-check-saved-objects-cli README with CI and manual usage docs (elastic#252557)
  [Discover] Add feature flag to make ESQL the default query mode (elastic#252268)
  Add maskProps.headerZindexLocation above to inspect component flyout (elastic#252543)
  [Security Solution][Atack/Alerts] Flyout header: Assignees  (elastic#252190)
  Upgrade EUI to v112.3.0 (elastic#252315)
  [Fleet] Make save_knowledge_base async in streaming state machine (elastic#252328)
  Upgrade @smithy/config-resolver 4.3.0 → 4.4.6 (elastic#252457)
  [Lens as API] Add colorMapping support for XY charts (ES|QL data layers) (elastic#252051)
  [WorkplaceAI] Add Google Drive data source and connector (elastic#250677)
  [Scout] Move GlobalSearch FTR tests to Scout (elastic#252201)
  [EDR Workflows] Fix osquery pack results display when agent clock is skewed (elastic#251417)
  [Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV (elastic#252486)
  [Entity Analytics] Update `host.ip` aggregation to remove painless script (elastic#252426)
  Address `@elastic/eui/require-table-caption` lint violations across `@elastic/obs-presentation-team` files (elastic#251050)
  Consolidate JSON stringify dependencies (elastic#251890)
  [index mgmt] Use esql instead of query dsl to get the index count (elastic#252422)
  Add Usage API Plugin (elastic#252434)
  Cases All Templates page (elastic#250372)
  [Agent Builder] Default value for optional params in ESQL tools (elastic#238472)
  [Fleet] Add upgrade_details.metadata.reason to AgentResponseSchema (elastic#252485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants