Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with mobile simulator on XDG #5633

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Mar 30, 2025

Description:

Compiling mobile simulator on develop gave a compile error about duplicate function definitions.
This fixes that issue also prepares for being able to add missing support for OpenURL and SendNotification in v2.7.0 instead of using the unsupported operating system error.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
This fix also prepares for being able to add missing support for OpenURL
and SendNotification in v2.7.0.
@Jacalz Jacalz added bug Something isn't working blocker Items that would block a forthcoming release labels Mar 30, 2025
@coveralls
Copy link

Coverage Status

coverage: 62.251% (+0.01%) from 62.241%
when pulling 91a6847 on Jacalz:fix-mobile-simulator-compile
into 62e7f55 on fyne-io:develop.

@Jacalz Jacalz merged commit ecaa745 into fyne-io:develop Mar 30, 2025
29 of 37 checks passed
@Jacalz Jacalz deleted the fix-mobile-simulator-compile branch March 30, 2025 21:07
Jacalz added a commit to Jacalz/fyne that referenced this pull request Mar 31, 2025
This avoids having to do fixes like fyne-io#5633 in the future. The problem came about because of tests runnign with the ci tag so the compile error in the other code path was missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working
3 participants