Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile of fyne_demo to mobile tests #5636

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Add compile of fyne_demo to mobile tests #5636

merged 1 commit into from
Mar 31, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Mar 31, 2025 •
edited
Loading

Description:

This avoids having to do fixes like #5633 in the future. The problem came about because of tests running with the ci tag so the compile error in the other code path was missed.

Checklist:

  • Tests included. <- Well, kind of?
  • Lint and formatter run with no errors.
  • Tests all pass.
@Jacalz
Add compile of fyne_demo to mobile tests
fb0c6af 
This avoids having to do fixes like fyne-io#5633 in the future. The problem came about because of tests runnign with the ci tag so the compile error in the other code path was missed.
@coveralls
Copy link

Coverage Status

coverage: 62.246% (+0.005%) from 62.241%
when pulling fb0c6af on Jacalz:mobile-simulator-compile
into ecaa745 on fyne-io:develop.
@Jacalz Jacalz merged commit a6a4090 into fyne-io:develop Mar 31, 2025
11 checks passed
@Jacalz Jacalz deleted the mobile-simulator-compile branch March 31, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Jacalz @coveralls @andydotxyz