fix(memberlist): Respect interface names config for advertise address #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clwluvw
force-pushed
the
memberlist-instanceaddr
branch
from
5696cdc to
4022274
Compare
chaudum
changed the title
If interface names are specified in common config, use this to fulfill the instance_addr with it. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
force-pushed
the
memberlist-instanceaddr
branch
from
4022274 to
d0839e0
Compare
|
@chaudum I fixed the lint errors, I guess :) |
chaudum
approved these changes
Nov 29, 2024
This was referenced Dec 23, 2024
This was referenced Feb 3, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If interface names are specified in common config, use this to fulfill the instance_addr with it.