feat(block-scheduler): job tracking & offset commits #15338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger := log.With(s.logger, "job", job.ID()) | ||
|
|
||
| if success { | ||
| // TODO(owen-d): do i need to increment offset here? |
There was a problem hiding this comment.
i think we need to commit job.Offsets().Max-1 given builders only consume upto but not including Max
| if err = s.offsetManager.Commit( | ||
| ctx, | ||
| job.Partition(), | ||
| job.Offsets().Max, |
There was a problem hiding this comment.
next jobs would start with job.Offsets().Max
Suggested change
| job.Offsets().Max, | |
| job.Offsets().Max-1, |
| s.queue.pending.Push( | ||
| NewJobWithMetadata( | ||
| job, | ||
| DefaultPriority, |
There was a problem hiding this comment.
shouldn't failed jobs instead get a higher priority?
There was a problem hiding this comment.
Yes, but I didn't want to complicate the PR further by adding logic for priority discovery on retries. I think this is best left for a followup PR.
| type priorityHeap[V any] struct { | ||
| less func(V, V) bool | ||
| heap []*item[V] | ||
| idx map[int]*item[V] // Maps index to item for efficient updates |
There was a problem hiding this comment.
do we use this for lookups? i don't see any references
|
|
||
| // Add new item | ||
| idx := pq.h.Len() | ||
| it := &item[V]{value: v, index: idx} |
There was a problem hiding this comment.
there is a bit of duplication, we update the index of the item here and within the heap's Push() method.
This was referenced Dec 23, 2024
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block Builder Scheduler Updates
Key improvements to the scheduler component focused on jobs and state management:
Job Handling
Queue Improvements
Other Changes
No migration needed - internal changes only. Next up: metrics, docs, and retry policies.