Skip to content

feat(block-scheduler): job tracking & offset commits #15338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 11, 2024
Merged

feat(block-scheduler): job tracking & offset commits #15338

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fe41286
key lookups for priority queue
owen-d Dec 10, 2024
f493c53
priorityqueue uses expected k/v annotations, works on scheduler handler
owen-d Dec 10, 2024
fddd01a
fleshing out support for non successful statuses
owen-d Dec 10, 2024
118a9b9
consolidate to `JobWithMetadata`
owen-d Dec 10, 2024
2608b00
remove old finished jobs from status map to avoid leaks
owen-d Dec 10, 2024
0215559
job fields are private to force constructor & accessor usage
owen-d Dec 10, 2024
5576b0c
removes unused builderID from scheduler interfaces
owen-d Dec 10, 2024
d14f9d6
sync job updates timestamps
owen-d Dec 10, 2024
67fc8ac
circular buffer lookup & metadata exists supporting fns
owen-d Dec 10, 2024
e6ed2e4
jobqueue logging, syncjob, default priority
owen-d Dec 10, 2024
d7e9062
scheduler job completion
owen-d Dec 10, 2024
db1406a
linting
owen-d Dec 10, 2024
de67588
scheduler queue fixes & tests
owen-d Dec 10, 2024
f096e8b
removes unused priority heap key map
owen-d Dec 11, 2024
497ac91
removes duplicate index-setting code in priority queue heap
owen-d Dec 11, 2024
c6ed241
commit max-1 in block-scheduler (max offset is exclusive)
owen-d Dec 11, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
commit max-1 in block-scheduler (max offset is exclusive)
  • Loading branch information
@owen-d
owen-d committed Dec 11, 2024
commit c6ed241b168646e63ed9e562d19b461d4445970e
3 changes: 1 addition & 2 deletions pkg/blockbuilder/scheduler/scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,10 @@ func (s *BlockScheduler) HandleCompleteJob(ctx context.Context, job *types.Job,
logger := log.With(s.logger, "job", job.ID())

if success {
// TODO(owen-d): do i need to increment offset here?
if err = s.offsetManager.Commit(
ctx,
job.Partition(),
job.Offsets().Max,
job.Offsets().Max-1, // max is exclusive, so commit max-1
); err == nil {
s.queue.MarkComplete(job.ID(), types.JobStatusComplete)
level.Info(logger).Log("msg", "job completed successfully")
Expand Down
Loading