fix(memberlist): allow resolution of advertise address from v6 interf… - #18250
Merged
Conversation
ashwanthgoli
commented
Jun 27, 2025
| t.Cfg.MemberlistKV.AdvertiseAddr, err = ring.GetInstanceAddr( | ||
| t.Cfg.MemberlistKV.AdvertiseAddr, | ||
| t.Cfg.Common.InstanceInterfaceNames, | ||
| t.Cfg.Common.Ring.InstanceInterfaceNames, |
Contributor
Author
There was a problem hiding this comment.
this line of change is a no-op as Common.Ring.InstanceInterfaceNames is set from Common.InstanceInterfaceNames unless the user has explicitly configured different values for them - not sure if doing that makes sense.
I updated this as memberlist is the underlying transport for the ring, it makes sense for it to inherit ring settings rather than loki level settings.
salvacorts
approved these changes
Jun 27, 2025
slim-bean
approved these changes
Jun 27, 2025
slim-bean
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, tricky to do this in a way that doesn't lead to an unexpected result for one version of a config vs another, I like this approach.
6 tasks
6 tasks
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#13940 introduced a change for memberlist to pick address from the interfaces defined in common
instance_interface_names(previously it iterated over all available interfaces), but the method used only resolves v4 addresses.This breaks memberlist for anyone using v6 only interfaces. This PR updates memberlist to look-up
t.Cfg.Common.Ring.EnableIPv6flag to enable the resolution of v6 addresses.Note: Individual components are allowed to specify their own list of interfaces using
<component_name>.ring.instance-interface-namesbut memberlist does not consider the component specific setting yet. This should be fixed in the long term.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR