Skip to content

fix(block-builder): return from Process call early if max offset is reached #15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix(block-builder): return from Process call early if max offset is reached #15073

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a9d14
fix(block-builder): return from Process call early if max offset is r…
ashwanthgoli Nov 22, 2024
0b25dee
review suggestions
ashwanthgoli Nov 25, 2024
7128249
fixup! review suggestions
ashwanthgoli Nov 25, 2024
dcc817d
Merge branch 'main' into fix-blockbuilder-processing
ashwanthgoli Nov 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review suggestions
  • Loading branch information
@ashwanthgoli
ashwanthgoli committed Nov 25, 2024
commit 0b25dee2a6abb6f71e77c74eb367d320cde78863
4 changes: 2 additions & 2 deletions pkg/blockbuilder/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (l *PartitionJobController) Process(ctx context.Context, offsets Offsets, c
err error
)

for boff.Ongoing() {
for lastOffset < offsets.Max && boff.Ongoing() {
var records []partition.Record
records, err = l.part.Poll(ctx, int(offsets.Max-lastOffset))
if err != nil {
Expand All @@ -153,7 +153,7 @@ func (l *PartitionJobController) Process(ctx context.Context, offsets Offsets, c
converted := make([]AppendInput, 0, len(records))
for _, record := range records {
if record.Offset >= offsets.Max {
return lastOffset, nil
break
}
lastOffset = record.Offset

Expand Down