Skip to content

fix(block-builder): return from Process call early if max offset is reached #15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix(block-builder): return from Process call early if max offset is reached #15073

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a9d14
fix(block-builder): return from Process call early if max offset is r…
ashwanthgoli Nov 22, 2024
0b25dee
review suggestions
ashwanthgoli Nov 25, 2024
7128249
fixup! review suggestions
ashwanthgoli Nov 25, 2024
dcc817d
Merge branch 'main' into fix-blockbuilder-processing
ashwanthgoli Nov 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into fix-blockbuilder-processing
  • Loading branch information
@ashwanthgoli
ashwanthgoli committed Nov 25, 2024
commit dcc817d172aad8c2071c1ccd21318bb697f18cf0
2 changes: 1 addition & 1 deletion pkg/kafka/partition/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ func (r *StdReader) FetchPartitionOffset(ctx context.Context, position SpecialOf

// Poll retrieves the next batch of records from Kafka
// Number of records fetched can be limited by configuring maxPollRecords to a non-zero value.
func (r *Reader) Poll(ctx context.Context, maxPollRecords int) ([]Record, error) {
func (r *StdReader) Poll(ctx context.Context, maxPollRecords int) ([]Record, error) {
start := time.Now()
fetches := r.client.PollRecords(ctx, maxPollRecords)
r.metrics.fetchWaitDuration.Observe(time.Since(start).Seconds())
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.