Skip to content

storage_prefix configuration no longer accept special characters, such as / #3968

Closed
@julienvey

Description

@julienvey

Describe the bug

Previously (until 1.11 I believe), we were able to set a configuration for bucket storage, where storage_prefix could be a "path", including special chars such as /

Now pyroscope complains about

failed creating pyroscope: storage prefix contains invalid characters, it may only contain digits and English alphabet letters

having / seems like a reasonable thing to have. Some buckets can be shared with other services, with prefix including those kind of chars.

To Reproduce

Steps to reproduce the behavior:

Start pyroscope 1.12.0 with a storage config like

storage:
      storage_prefix: pyroscope/some-env/
      backend: s3
      ...

It fails to start with the following error

failed creating pyroscope: storage prefix contains invalid characters, it may only contain digits and English alphabet letters

Expected behavior

special chars such as / or - should be allowed in the storage_prefix configuration option

Environment

Any

Additional Context

I think it was introduced by this change #3837

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions