Description
Describe the bug
Previously (until 1.11 I believe), we were able to set a configuration for bucket storage, where storage_prefix
could be a "path", including special chars such as /
Now pyroscope complains about
failed creating pyroscope: storage prefix contains invalid characters, it may only contain digits and English alphabet letters
having /
seems like a reasonable thing to have. Some buckets can be shared with other services, with prefix including those kind of chars.
To Reproduce
Steps to reproduce the behavior:
Start pyroscope 1.12.0 with a storage config like
storage:
storage_prefix: pyroscope/some-env/
backend: s3
...
It fails to start with the following error
failed creating pyroscope: storage prefix contains invalid characters, it may only contain digits and English alphabet letters
Expected behavior
special chars such as /
or -
should be allowed in the storage_prefix
configuration option
Environment
Any
Additional Context
I think it was introduced by this change #3837