Skip to content

fix: Storage prefix validation #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: Storage prefix validation #4044

merged 1 commit into from
Mar 25, 2025

Conversation

simonswine
Copy link
Contributor

Our validation has been overly strict, since inception of the project.
Although we failed to call the validate alltogether. This was fixed in

This PR loosens the criteria accordingly

Fixes #3968
@simonswine
fix: Storage prefix validation
df0a14d 
Our validation has been overly strict, since inception of the project.
Although we failed to call the validate alltogether. This was fixed in

This PR loosens the criteria accordingly

Fixes grafana#3968
@simonswine simonswine added type/bug Something isn't working backport release/v1.11 This label will backport a merged PR to the release/v1.11 branch backport release/v1.12 This label will backport a merged PR to the release/v1.12 branch labels Mar 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR must be merged before a backport PR will be created.
1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This PR must be merged before a backport PR will be created.
@simonswine simonswine marked this pull request as ready for review March 24, 2025 16:12
@simonswine simonswine requested a review from a team as a code owner March 24, 2025 16:12
@simonswine simonswine added backport release/v1.13 This label will backport a merged PR to the release/v1.13 branch and removed backport release/v1.11 This label will backport a merged PR to the release/v1.11 branch labels Mar 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR must be merged before a backport PR will be created.
@simonswine simonswine merged commit ed11e4a into grafana:main Mar 25, 2025
24 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
@simonswine @grafana-delivery-bot
fix: Storage prefix validation (#4044)
1886b85 
Our validation has been overly strict, since inception of the project.
Although we failed to call the validate alltogether. This was fixed in

This PR loosens the criteria accordingly

Fixes #3968

(cherry picked from commit ed11e4a)
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
@simonswine @grafana-delivery-bot
fix: Storage prefix validation (#4044)
c7629c0 
Our validation has been overly strict, since inception of the project.
Although we failed to call the validate alltogether. This was fixed in

This PR loosens the criteria accordingly

Fixes #3968

(cherry picked from commit ed11e4a)
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Merged
simonswine added a commit that referenced this pull request Mar 25, 2025
@github-actions @simonswine
fix: Storage prefix validation (#4044) (#4047)
445c20d 
Our validation has been overly strict, since inception of the project.
Although we failed to call the validate alltogether. This was fixed in

This PR loosens the criteria accordingly

Fixes #3968

(cherry picked from commit ed11e4a)

Co-authored-by: Christian Simon <simon@swine.de>
simonswine added a commit that referenced this pull request Mar 25, 2025
@github-actions @simonswine
fix: Storage prefix validation (#4044) (#4048)
f1b77e2 
Our validation has been overly strict, since inception of the project.
Although we failed to call the validate alltogether. This was fixed in

This PR loosens the criteria accordingly

Fixes #3968

(cherry picked from commit ed11e4a)

Co-authored-by: Christian Simon <simon@swine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.12 This label will backport a merged PR to the release/v1.12 branch backport release/v1.13 This label will backport a merged PR to the release/v1.13 branch type/bug Something isn't working
2 participants
@simonswine @korniltsev