change: remove ingesters and compactor alerts - #6369
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1db52bc6b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c49e5e8db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| alert: 'TempoBlockBuildersPartitionsMismatch', | ||
| expr: ||| | ||
| max(tempo_partition_ring_partitions{name=~"ingester-partitions|livestore-partitions", state=~"Active|Inactive"}) by (namespace,cluster) | ||
| max(tempo_partition_ring_partitions{name=~"livestore-partitions", state=~"Active|Inactive"}) by (namespace,cluster) | ||
| > | ||
| sum(tempo_block_builder_owned_partitions) by(namespace,cluster) |
There was a problem hiding this comment.
The updated expression only checks livestore-partitions and drops ingester-partitions. The ingester module still defines and uses the ingester-partitions ring (modules/ingester/ingester.go), so deployments that haven’t migrated off ingesters will no longer get the block‑builder mismatch alert even if partitions are unowned. That’s a regression in monitoring coverage for those clusters: the alert will stay silent while the block‑builder falls behind the ingester partition ring. Consider keeping ingester-partitions in the selector (or gating it by configuration) until ingesters are fully removed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch but I'm aware of this
|
Are we a bit early on this? IE should this only apply to 3.0? |
We already cut 2.10. This is already 3.0 |
* change: remove ingesters and compactors alerts * change: remove ingesters and compactors alerts * remove unused files * alerts * fmt * changelog
3 participants
What this PR does:
This pr removes alerts from ingesters and compactors. It also update the runbooks. These components have been deprecated to favor live-store and backend worker and scheduler.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]