-
Notifications
You must be signed in to change notification settings - Fork 735
change: remove ingesters and compactor alerts #6369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9361fa5
change: remove ingesters and compactors alerts
javiermolinar 256ae70
change: remove ingesters and compactors alerts
javiermolinar 1db52bc
remove unused files
javiermolinar 1ce5612
alerts
javiermolinar 1c49e5e
fmt
javiermolinar 1701904
Merge branch 'main' into remove-ingesters-and-compactor-alerts
javiermolinar 937070e
changelog
javiermolinar ce2de0b
Trigger Build
javiermolinar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated expression only checks
livestore-partitionsand dropsingester-partitions. The ingester module still defines and uses theingester-partitionsring (modules/ingester/ingester.go), so deployments that haven’t migrated off ingesters will no longer get the block‑builder mismatch alert even if partitions are unowned. That’s a regression in monitoring coverage for those clusters: the alert will stay silent while the block‑builder falls behind the ingester partition ring. Consider keepingingester-partitionsin the selector (or gating it by configuration) until ingesters are fully removed.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch but I'm aware of this