Skip to content

Improving debug experience - #5

Closed
Juliaj wants to merge 2 commits into
hardware-fork:mainfrom
Juliaj:debug_file_not_found_2
Closed

Improving debug experience#5
Juliaj wants to merge 2 commits into
hardware-fork:mainfrom
Juliaj:debug_file_not_found_2

Conversation

@Juliaj

@Juliaj Juliaj commented Mar 3, 2026

Copy link
Copy Markdown

Main changes

  • Introduces a debug task to check webcam and serial port, pixi run check-devices.
  • Adds a dataflow file to run Demo for team_krishan.

@kbhakt,

I couldn't repro the issue on my Windows machine. Can you run following command? If you still see errors, copy/paste the output for me. Please check Demo/dataflow_tracking_real_team_krishan.yml before running following steps.

# From git bash terminal, run following, fix any errors reported. See the output from my machine at the end.
pixi run check-devices

# Run following from the project root, i.e. outside Demo folder
pixi run dora build Demo/dataflow_tracking_real_team_krishan.yml   # once

# When running following, check whether you see following line from the console log
# hand_controller: stdout    Opening "../config/calibration/l_hand_team_krishan.toml"
pixi run dora run Demo/dataflow_tracking_real_team_krishan.yml

pixi run check-devices output following on my machine

=== AmazingHand device check ===                                                                                                                                                 

Webcam indices:
  0: 640x480
  Use index 0 in HandTracking unless you have multiple cameras.

Serial ports:
  COM3: USB-Enhanced-SERIAL CH343 (COM3) (USB, likely hand)
  Use the USB device in dataflow YAML --serialport.
@Juliaj
Juliaj requested a review from kbhakt March 3, 2026 04:37
@kbhakt

kbhakt commented Mar 3, 2026

Copy link
Copy Markdown

@Juliaj I want to checkout the branch "debug_file_not_found_2" but only see the main branch on the hardware_fork/Amazing_Hand?

Is there a reason for this? I was able in previous PR's to checkout the branch and try the code.

I can manually copy the files over or just approve the PR so it can be merged into main. Thoughts?

@kbhakt

kbhakt commented Mar 3, 2026

Copy link
Copy Markdown

Also do you squash and delete branches after you close the PR?

@kbhakt

kbhakt commented Mar 3, 2026

Copy link
Copy Markdown

oh I realized that the branch is on your personal fork of the Amazing Hand. For future PR's can we base on the hardware-fork repo?

@Juliaj

Juliaj commented Mar 3, 2026

Copy link
Copy Markdown
Author

oh I realized that the branch is on your personal fork of the Amazing Hand. For future PR's can we base on the hardware-fork repo?

We can definitely do this. Do you have any preference on the naming, for example for this PR, I can push to a branch jj/fix/debug_file_not_found_2.

Also do you squash and delete branches after you close the PR?

Done, I have set auto delete head branches. And yes, always do squash merge.

@Juliaj

Juliaj commented Mar 3, 2026

Copy link
Copy Markdown
Author

Close in favor of #6 which head branch is directly of this repo.

@Juliaj Juliaj closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants