feat: landing-chrome 404 page for unknown routes - #541
Draft
ghesp wants to merge 3 commits into
Draft
Conversation
Render a static site 404 with homepage Header/Footer so missing single-segment paths hit pages/404.tsx instead of the catch-all. Co-authored-by: ghesp <ghesp@users.noreply.github.com>
|
|
|
🚅 Deployed to the docs.page-pr-541 environment in docs.page
|
railway-app
Bot
temporarily deployed
to
docs.page / docs.page-pr-541
August 28, 2026 09:58
Destroyed
Next.js 16 mixed App + Pages routing serves the App builtin 404 when
getServerSideProps returns { notFound: true }. Unknown single-segment
paths now set 404 and render the landing-chrome page instead.
Co-authored-by: ghesp <ghesp@users.noreply.github.com>
railway-app
Bot
temporarily deployed
to
docs.page / docs.page-pr-541
August 28, 2026 10:01
Destroyed
Reuse Homepage Background so the 404 sits on the periwinkle field. Hide Footer closer on this page only; landing Footer is unchanged. Co-authored-by: ghesp <ghesp@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice is a static 404 with landing chrome; shader dissolve of the 404 into the 22px spot grid comes next.
Unknown routes now render a real landing-chrome 404 instead of the docs empty state. The page reuses the homepage
Header,Footerbar, andBackground(periwinkle atmosphere), centers a honey 404 block, and uses existing landing tokens (Lexend Light, JetBrains Mono, honey pill CTA).This does not add the dot-grid dissolve of the 404 number, and does not touch the feature-card sticky work on #535. Docs-site misses (
/owner/repo/...with a missing.mdx) still useDocsNotFoundPage.Scope
app/(hosted site, MCP, Ask AI)packages/cli/packages/mdx-bundler/docs/(product documentation)Type of change
Test plan
bun run checkpasses locallybun dev)docs/(if user-facing) — N/A for this sliceBackground); closer CTA is gone; footer bar (logo, Built by Invertase, ©, Privacy, Terms) remains. Homepage Footer closer unchanged.Notes for reviewers
pages/404.tsxholds the static page. The optional catch-all ([[...path]].tsx) still matches unknown URLs, so a 1-segment miss setsres.statusCode = 404and renderskind: "siteNotFound"rather than returning{ notFound: true }.{ notFound: true }is served as Next.js 16’s App Router builtin 404 (__next_builtin__not-found.js), which is why docs misses already render from the catch-all instead of relying onnotFound: true.Footergained an optionalshowCloser(defaulttrue) so this page can drop the “Bring your docs…” closer without changing the landing page.?debugon a 1-segment path still shows the existing debug card.DocsNotFoundPage).Follow-up from review: landing
Backgroundon the 404; closer CTA removed on this page only.