feat: promote InferenceSet to v1beta1 and enable EnableInferenceSetController by default by andyzhangx · Pull Request #2112 · kaito-project/kaito

andyzhangx · 2026-06-17T07:17:03Z

Description

Changes

Promote InferenceSet CRD to v1beta1 - Add InferenceSet types to api/v1beta1/ with validation, defaulting, and DeepCopy
Set v1beta1 as the storage version - +kubebuilder:storageversion moved from v1alpha1 to v1beta1; CRD updated with v1beta1 as storage and v1alpha1 still served for backward compatibility
Enable EnableInferenceSetController feature gate by default - Change default from false to true (both in code and Helm chart)
Migrate all internal references - All controllers (InferenceSet, drift, autoupgrade), webhooks, manifests, metrics, and utilities now use kaitov1beta1.InferenceSet* types
Register both v1alpha1 and v1beta1 InferenceSet in webhooks - Ensures backward compatibility during CRD transition
Update CRD manifest - config/crd/bases/kaito.sh_inferencesets.yaml and Helm chart template now define both v1alpha1 and v1beta1
Migrate E2E tests - E2E test helpers and functions updated to use v1beta1 InferenceSet types
Use GetInferenceSetRuntimeName helper - Eliminated duplicated runtime selection logic in inferencePoolTargetPort, removed cross-version kaitov1alpha1 dependency
Fix metrics phase label - determineInferenceSetPhase now returns "succeeded" to match metric bucket labels

CRD Version Configuration

The CRD now defines two versions with the following settings:

Version	`served`	`storage`	Meaning
v1alpha1	true	false	API server still accepts v1alpha1 requests (backward compatible for existing clients/scripts), but objects are no longer stored in this format
v1beta1	true	true	API server accepts v1beta1 requests, and all objects are stored in etcd using this format

served: Whether the API server exposes this version as an endpoint. When true, clients can use this version in their API requests (e.g., kubectl get inferencesets.v1alpha1.kaito.sh still works).
storage: Which version format is used to persist objects in etcd. Only one version can be the storage version. The API server automatically converts between served versions and the storage version on read/write.

Motivation

InferenceSet has been stable since v0.6.x and is actively used for multi-replica inference workloads
P/D disaggregation (MultiRoleInference) depends on InferenceSet being enabled
Users currently must manually set --feature-gates=enableInferenceSetController=true which is unnecessary friction
Aligns with Kubernetes API maturity conventions (alpha → beta when API is stable)

Storage Version

v1beta1 is now the storage version — all new objects are stored as v1beta1
v1alpha1 remains served for backward compatibility (existing clients can still read/write using v1alpha1 API)
Since v1alpha1 and v1beta1 share identical Spec/Status schemas, no conversion webhook is needed at this time

Related Issues

Related to feat: support P/D disaggregation #2093 (P/D disaggregation support)

Complete the InferenceSet v1beta1 promotion: - Move +kubebuilder:storageversion marker from v1alpha1 to v1beta1 - Migrate controller reconcile loop to use kaitov1beta1.InferenceSet - Migrate utility functions (UpdateInferenceSetStatus, etc.) to v1beta1 - Migrate drift controller to v1beta1 types - Migrate metrics to v1beta1 types - Align all tests to v1beta1 types - Update ownerReference GVKs to v1beta1 - Update test fixtures with correct annotation keys (kaito.io)

…ifests tests

…s to v1beta1 in runner_test.go

- Add v1beta1 version entry to kaito.sh_inferencesets.yaml CRD with storage: true - Set v1alpha1 to storage: false (still served for backward compatibility) - v1beta1 markers already have +kubebuilder:storageversion

The e2e test installs InferenceSet CRD from the Helm chart template, which only had v1alpha1. Since the controller now uses kaito.sh/v1beta1, the CRD must serve v1beta1. Copy the updated CRD (with both v1alpha1 served and v1beta1 as storage version) to the Helm chart template.

… tests to v1beta1 - Set featureGates.enableInferenceSetController=true in Helm values.yaml - Update README to reflect new default - Migrate e2e test helpers and test functions to use kaitov1beta1.InferenceSet - Update InferenceSetList and condition type references to v1beta1

Remove GetInferenceSetRuntimeName, IsRunBenchmarkEnabled, and ShouldRunBenchmark from api/v1alpha1/labels.go since the controller now uses the v1beta1 equivalents. Also remove the corresponding tests from labels_test.go.

Copilot

Pull request overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

api/v1beta1/zz_generated.deepcopy.go: Generated file

- Fix metrics phase: return 'succeeded' (not 'ready') to match metric bucket labels in monitorInferenceSets - Use GetInferenceSetRuntimeName helper in inferencePoolTargetPort to eliminate duplicated runtime selection logic and remove v1alpha1 dependency (kaitov1alpha1.MultiRoleInferenceRoleDecode) - Remove unused featuregates import from manifests.go - Rename receiver from 'w' to 'i' in InferenceSet.SetDefaults - Use IsInferenceSetBenchmarkEnabled in controller test instead of inline annotation check - Add missing 'config' field to Metric schema in CRD manifest Signed-off-by: andyzhangx <andyzhangx@live.com>

tc.inferenceset is already *v1beta1.InferenceSet, no need for &. Signed-off-by: andyzhangx <andyzhangx@live.com>

Copilot

Pull request overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

api/v1beta1/zz_generated.deepcopy.go: Generated file

- Define InferenceRoleDecode constant in v1beta1/labels.go and use it in inferencePoolTargetPort instead of hardcoded "decode" string - Lower webhook validation logs from Info to V(2) to reduce noise on every create/update request Signed-off-by: andyzhangx <andyzhangx@live.com>

zhuangqh · 2026-06-22T01:50:44Z

please leave v1alpha1 pkg unchanged. others looks good.

Revert the removal of GetInferenceSetRuntimeName, IsRunBenchmarkEnabled, ShouldRunBenchmark from api/v1alpha1/labels.go and their tests from labels_test.go. These functions are still needed in the v1alpha1 package.

The test functions for GetInferenceSetRuntimeName are no longer needed in the v1alpha1 package.

Restore TestGetInferenceSetRuntimeName tests in api/v1alpha1/labels_test.go.

…t.go

…bels_test.go" This reverts commit 10cad30.

Keep the original feature-gate-based runtime detection logic instead of calling GetInferenceSetRuntimeName. Only the type signature changes from v1alpha1 to v1beta1 for the InferenceSet promotion.

Copilot

Pull request overview

Copilot reviewed 33 out of 34 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

api/v1beta1/zz_generated.deepcopy.go: Generated file

Signed-off-by: Andy Zhang <xiazhang@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 33 out of 34 changed files in this pull request and generated no new comments.

Files not reviewed (1)

api/v1beta1/zz_generated.deepcopy.go: Generated file

andyzhangx requested review from Fei-Guo, chewong and zhuangqh as code owners June 17, 2026 07:17

github-project-automation Bot added this to KAITO Roadmap Jun 17, 2026

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:17 — with GitHub Actions Failure

andyzhangx temporarily deployed to unit-tests June 17, 2026 07:17 — with GitHub Actions Inactive

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:17 — with GitHub Actions Failure

andyzhangx temporarily deployed to unit-tests June 17, 2026 07:17 — with GitHub Actions Inactive

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:17 — with GitHub Actions Error

andyzhangx force-pushed the feat/inferenceset-beta-promotion branch from a300da2 to 958f8da Compare June 17, 2026 07:22

andyzhangx had a problem deploying to unit-tests June 17, 2026 07:23 — with GitHub Actions Failure

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:23 — with GitHub Actions Failure

andyzhangx temporarily deployed to unit-tests June 17, 2026 07:23 — with GitHub Actions Inactive

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:23 — with GitHub Actions Failure

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:23 — with GitHub Actions Error

andyzhangx force-pushed the feat/inferenceset-beta-promotion branch from 958f8da to 9e055d3 Compare June 17, 2026 07:30

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:30 — with GitHub Actions Failure

andyzhangx temporarily deployed to unit-tests June 17, 2026 07:30 — with GitHub Actions Inactive

andyzhangx had a problem deploying to unit-tests June 17, 2026 07:30 — with GitHub Actions Failure

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:30 — with GitHub Actions Error

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:55 — with GitHub Actions Failure

andyzhangx had a problem deploying to unit-tests June 17, 2026 07:55 — with GitHub Actions Failure

andyzhangx had a problem deploying to unit-tests June 17, 2026 07:55 — with GitHub Actions Error

andyzhangx had a problem deploying to e2e-test June 17, 2026 07:55 — with GitHub Actions Error

andyzhangx force-pushed the feat/inferenceset-beta-promotion branch from b615586 to 6e93b17 Compare June 17, 2026 07:58

andyzhangx had a problem deploying to unit-tests June 17, 2026 07:58 — with GitHub Actions Failure

andyzhangx added 11 commits June 20, 2026 04:15

fix: correct v1alpha1->v1beta1 type mismatches in autoupgrade and man…

13be4ed

…ifests tests

fix: use v1beta1.AutoUpgradeStatus in runner_test.go

9396dde

fix: convert makeInferenceSet and remaining v1alpha1.InferenceSet ref…

f708a0c

…s to v1beta1 in runner_test.go

feat: add v1beta1 as storage version in InferenceSet CRD

1c3cffd

- Add v1beta1 version entry to kaito.sh_inferencesets.yaml CRD with storage: true - Set v1alpha1 to storage: false (still served for backward compatibility) - v1beta1 markers already have +kubebuilder:storageversion

fix: remove unused kaitov1alpha1 import from e2e utils.go

f58d3ff

fix: remove unused kaitov1alpha1 import from preset_test.go

fcb146f

fix and rebase

fd4096d

Copilot AI reviewed Jun 20, 2026

View reviewed changes

Comment thread pkg/inferenceset/metrics.go

Comment thread pkg/inferenceset/metrics_test.go

andyzhangx added 2 commits June 20, 2026 07:08

fix: pass pointer directly to IsInferenceSetBenchmarkEnabled

a0ee6cc

tc.inferenceset is already *v1beta1.InferenceSet, no need for &. Signed-off-by: andyzhangx <andyzhangx@live.com>

Copilot AI reviewed Jun 20, 2026

View reviewed changes

Comment thread pkg/workspace/manifests/manifests.go Outdated

Comment thread pkg/inferenceset/metrics.go

Comment thread api/v1beta1/inferenceset_validation.go

andyzhangx added 7 commits June 22, 2026 02:16

revert: restore v1alpha1 InferenceSet helper functions and tests

d7769b1

Revert the removal of GetInferenceSetRuntimeName, IsRunBenchmarkEnabled, ShouldRunBenchmark from api/v1alpha1/labels.go and their tests from labels_test.go. These functions are still needed in the v1alpha1 package.

revert: remove restored v1alpha1 labels_test.go functions

8c9d501

The test functions for GetInferenceSetRuntimeName are no longer needed in the v1alpha1 package.

revert: restore v1alpha1 labels_test.go test functions

9081677

Restore TestGetInferenceSetRuntimeName tests in api/v1alpha1/labels_test.go.

fix: remove TestInferenceSetBenchmarkHelpers from v1alpha1 labels_tes…

10cad30

…t.go

Revert "fix: remove TestInferenceSetBenchmarkHelpers from v1alpha1 la…

026b26c

…bels_test.go" This reverts commit 10cad30.

fix: restore original inferencePoolTargetPort logic with v1beta1 types

8bb9932

Keep the original feature-gate-based runtime detection logic instead of calling GetInferenceSetRuntimeName. Only the type signature changes from v1alpha1 to v1beta1 for the InferenceSet promotion.

fix: correct featuregates import path

abc9e5e

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread pkg/inferenceset/metrics.go

Comment thread pkg/inferenceset/metrics_test.go

Comment thread pkg/workspace/manifests/manifests.go Outdated

fix: restore alphabetical import order in manifests.go

e8792b1

zhuangqh approved these changes Jun 22, 2026

View reviewed changes

Merge branch 'main' into feat/inferenceset-beta-promotion

aff2d9d

Signed-off-by: Andy Zhang <xiazhang@microsoft.com>

Copilot AI reviewed Jun 22, 2026

View reviewed changes

andyzhangx mentioned this pull request Jun 22, 2026

[WIP] test: remove redundant enableInferenceSetController feature gate from CI #2137

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: promote InferenceSet to v1beta1 and enable EnableInferenceSetController by default - #2112

feat: promote InferenceSet to v1beta1 and enable EnableInferenceSetController by default#2112
zhuangqh merged 33 commits into
kaito-project:mainfrom
andyzhangx:feat/inferenceset-beta-promotion

andyzhangx commented Jun 17, 2026 •

edited

Loading

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

zhuangqh commented Jun 22, 2026 •

edited

Loading

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Labels

3 participants

Uh oh!

Conversation

andyzhangx commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

CRD Version Configuration

Motivation

Storage Version

Related Issues

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

zhuangqh commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Labels

3 participants

andyzhangx commented Jun 17, 2026 •

edited

Loading

zhuangqh commented Jun 22, 2026 •

edited

Loading