[WIP] test: remove redundant enableInferenceSetController feature gate from CI - #2137
Open
andyzhangx wants to merge 1 commit into
Open
[WIP] test: remove redundant enableInferenceSetController feature gate from CI#2137andyzhangx wants to merge 1 commit into
andyzhangx wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up CI configuration by removing the explicit featureGates.enableInferenceSetController=true Helm value from workflows/composite actions, based on the assumption that the feature gate now defaults to enabled.
Changes:
- Removed
--set featureGates.enableInferenceSetController=truefrom Helm install/upgrade commands in CI workflows. - Removed the AIKit workflow verification that the controller args include
enableInferenceSetController=true. - Removed the same feature gate from the E2E base setup composite action’s
HELM_INSTALL_EXTRA_ARGS.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/base-image-auto-upgrade-test.yaml |
Removes the InferenceSet controller feature gate from old-chart install and current-chart upgrade steps. |
.github/workflows/aikit.yaml |
Removes the InferenceSet controller feature gate from Helm rendering and drops the corresponding arg verification. |
.github/actions/e2e-base-setup/action.yaml |
Removes the InferenceSet controller feature gate from the shared E2E Helm install extra args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+85
to
+88
| helm install kaito-workspace kaito/workspace \ | ||
| --version ${{ env.OLD_CHART_VERSION }} \ | ||
| --namespace kaito-workspace \ | ||
| --create-namespace \ | ||
| --set featureGates.enableInferenceSetController=true | ||
| --create-namespace |
Collaborator
Author
There was a problem hiding this comment.
Fixed in 435a17c — restored --set featureGates.enableInferenceSetController=true for the old chart install step.
Comment on lines
176
to
179
| helm upgrade kaito-workspace ./charts/kaito/workspace \ | ||
| --namespace kaito-workspace \ | ||
| --set featureGates.enableBaseImageAutoUpgrade=true \ | ||
| --set featureGates.enableInferenceSetController=true \ | ||
| --take-ownership |
| # CSI Local Node cannot be configured to not deploy and it crashes on kind on github runners for unknown reasons | ||
| # so we need to filter it out its components | ||
| helm template kaito-workspace ./charts/kaito/workspace --namespace ${{ env.KAITO_NAMESPACE }} --set nodeProvisioner="byo" --set featureGates.enableInferenceSetController="true" --set featureGates.gatewayAPIInferenceExtension="true" --include-crds --debug --wait | awk ' | ||
| helm template kaito-workspace ./charts/kaito/workspace --namespace ${{ env.KAITO_NAMESPACE }} --set nodeProvisioner="byo" --set featureGates.gatewayAPIInferenceExtension="true" --include-crds --debug --wait | awk ' |
Contributor
|
Failed to generate code suggestions for PR |
andyzhangx
changed the title
Since enableInferenceSetController now defaults to true starting v0.11.0 (beta promotion, kaito-project#2112), the explicit --set featureGates.enableInferenceSetController=true in workflows that install/upgrade to the current chart is redundant. For workflows that install an old chart version (e.g., v0.10.0), the flag must remain because older charts default enableInferenceSetController to false. Files changed: - .github/actions/e2e-base-setup/action.yaml: remove from HELM_INSTALL_EXTRA_ARGS (current chart). - .github/workflows/aikit.yaml: remove from 'helm template' and the verification check for this feature gate (current chart). - .github/workflows/base-image-auto-upgrade-test.yaml: remove from the two 'Upgrade to current chart' steps only; keep the two 'Install old chart' steps unchanged (old chart still defaults the gate to false). Signed-off-by: andyzhangx <xiazhang@microsoft.com>
andyzhangx
force-pushed
the
test/remove-inferenceset-feature-gate
branch
from
July 25, 2026 14:17
93e5c73 to
e54446f
Compare
andyzhangx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it
Since
enableInferenceSetControllernow defaults totruestarting v0.11.0 (beta promotion, #2112), the explicit--set featureGates.enableInferenceSetController=truein CI workflows is redundant for workflows that install/upgrade to the current chart.For workflows that install an old chart version (e.g.,
base-image-auto-upgrade-test.yamlwith v0.10.0), the flag must remain because older charts defaultenableInferenceSetControllertofalse.Files changed
.github/actions/e2e-base-setup/action.yamlenableInferenceSetController=truefromHELM_INSTALL_EXTRA_ARGS(uses current chart).github/workflows/aikit.yamlhelm templatecommand and the corresponding verification check (uses current chart).github/workflows/base-image-auto-upgrade-test.yamlWhich issue(s) this PR fixes
N/A - CI cleanup following InferenceSet beta promotion
Related PRs
true)