v3.108.0 - #2058
v3.108.0#2058
Conversation
Co-authored-by: panther-bot-automation <github-service-account-automation@panther.io>
PR SummaryMedium Risk Overview Reworks agent/tooling docs by introducing Changes local developer workflow by installing a custom Reviewed by Cursor Bugbot for commit fe45cce. Bugbot is set up for automated code reviews on this repo. Configure here. |
| update_type = _extract_update_type(str(entry)) | ||
| if update_type and update_type != PARENT_EVENT_TYPE: | ||
| result.append(update_type) | ||
| return result |
There was a problem hiding this comment.
Regex extracts nested type instead of top-level type
Low Severity
_extract_update_type uses re.search to find the first 'type': '...' match in a serialized dict string. The docstring claims serializing each entry individually avoids capturing nested type values, but that's incorrect — nested objects within each entry are still part of its str() output. If JSON field ordering places a nested object before the top-level type key (e.g., {"current_value": [{"type": "github"}], "type": "vcs_connections"}), the regex matches the nested "github" instead of "vcs_connections". Only affects title() display, not detection logic.
Reviewed by Cursor Bugbot for commit b326ddf. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fe45cce. Configure here.
| "deleted_user_email": event.get("deleted_user_email"), | ||
| } | ||
| context.update({k: v for k, v in optional_context.items() if v is not None}) | ||
| return context |
There was a problem hiding this comment.
New global helper module has no unit tests
Medium Severity
The new panther_anthropic_helpers.py module has no corresponding test file and no tests in global_helpers_test.py. The repo's own AGENTS.md §14 states "Adding new helper modules requires adding corresponding *_test.py files; make global-helpers-unit-test enforces this." Every other helper imported in global_helpers_test.py has test coverage, but panther_anthropic_helpers is absent. Both anthropic_actor_id (with its or-chaining fallback logic) and anthropic_alert_context (with its optional-context filtering) contain logic worth validating.
Reviewed by Cursor Bugbot for commit fe45cce. Configure here.


Background
Changes
Testing